From: Palmer Dabbelt <palmer@sifive.com>
To: schwab@suse.de
Cc: Jim Wilson <jimw@sifive.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] RISC-V: Fix elfutils testsuite unwind failures.
Date: Wed, 13 Feb 2019 14:25:20 -0800 (PST) [thread overview]
Message-ID: <mhng-5213197b-9863-475f-a28c-5cd9e0713962@palmer-si-x1c4> (raw)
In-Reply-To: <mvmftsrr6ld.fsf@suse.de>
On Wed, 13 Feb 2019 08:33:34 PST (-0800), schwab@suse.de wrote:
> On Jan 13 2019, Jim Wilson <jimw@sifive.com> wrote:
>
>> Unfortunately, the testcase isn't working as expected and I don't know why.
>> The testcase passes even when my clone.S patch is not installed.
>
> I don't see that here, with the current tools from openSUSE Factory.
> There many be some (bad?) luck involved, since it's undefined territory.
>
>> [BZ #24040]
>> * elf/Makefile (CFLAGS-tst-unwind-main.c): Add -DUSE_PTHREADS=0.
>> * elf/tst-unwind-main.c: If USE_PTHEADS, include pthread.h and error.h
>> (func): New.
>> (main): If USE_PTHREADS, call pthread_create to run func. Otherwise
>> call func directly.
>> * nptl/Makefile (tests): Add tst-unwind-thread.
>> (CFLAGS-tst-unwind-thread.c): Define.
>> * nptl/tst-unwind-thread.c: New file.
>> * sysdeps/unix/sysv/linux/riscv/clone.S (__thread_start): Mark ra
>> as undefined.
>
> Ok.
Thanks. I committed this.
next prev parent reply other threads:[~2019-02-13 22:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 23:48 [PATCH] RISC-V: Fix elfutils testsuite unwind failures Jim Wilson
2019-01-14 13:38 ` Florian Weimer
2019-01-14 17:29 ` Jim Wilson
2019-01-17 17:05 ` Mark Wielaard
2019-01-21 5:55 ` Jim Wilson
2019-01-22 13:28 ` Mark Wielaard
2019-01-23 6:58 ` Jim Wilson
2019-01-24 2:51 ` Palmer Dabbelt
2019-01-28 21:18 ` Jim Wilson
2019-01-28 22:44 ` DJ Delorie
2019-01-28 23:10 ` Jim Wilson
2019-02-04 22:37 ` DJ Delorie
2019-02-04 23:01 ` Jim Wilson
2019-02-04 23:33 ` DJ Delorie
2019-02-04 23:46 ` Joseph Myers
2019-02-04 23:57 ` DJ Delorie
2019-02-05 0:01 ` Joseph Myers
2019-02-12 20:08 ` ping^2 " Jim Wilson
2019-02-13 12:03 ` Andreas Schwab
2019-02-13 16:33 ` Andreas Schwab
2019-02-13 22:25 ` Palmer Dabbelt [this message]
2019-02-18 9:56 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-5213197b-9863-475f-a28c-5cd9e0713962@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=jimw@sifive.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).