From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A7FC01F45E for ; Tue, 11 Feb 2020 20:58:03 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=ZtSAJMm3CaCwYxZW 79KphRXvSfJ9sPw7Q35FJy83xO6jUeQ9MshSNhGJlliW1rnM7ZqVmh0vsUnumNTl LxAidTNpOihVEh84RIJVIFU0WoKK2DnLCxlIY1VPFVy03DmV1KeA4E1LgHEPry7r eA8UmZVBlmIub5Wf+RSUeW2bIFU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=gvLAcXSdj91/05tDqOWCzc X1bQM=; b=SnUMG82FxI0Sqh6iFJZ8wpbn8KDBKBbaPOSvV+29nOuQEvUBRFKXD5 cbxG74A1AxyYIlCazs1IJ0UjZ97FtRg5+/Y9VEkvvcYcJG+RECY4krMwAgt7wLMN U+vW1fm21+Z6OqTJjuGbzgM2/3pSgnu3B9cNYo9Cn6oX1PrCVDpoQ= Received: (qmail 125814 invoked by alias); 11 Feb 2020 20:58:01 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 125790 invoked by uid 89); 11 Feb 2020 20:58:00 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a2xffiWWFZeTR5/2iky2+8Yv4P2Xjn7SXCksHJ7BjC4=; b=QrrU/e/zH9fwsMDSgC46wZt1qfcx79xNrXs+G1floCKk2rgtYYmAaEEnjcOLzDXQYy dQcHvKzcowE4FH4pPi5FtRL+0mW9ZwDeo7DNrksCdgS1VBfNTuomnOTkNKd/kg7xdiCu 9YusBLJ6ewu79ZqHuODrvR6ZXoGU51G3p9YSCLus3lVaN4J5bFIq5e8rKP/cb+kSHlGM nuOb8UrVlpYVIXiJWtHWkpjEKJl4olD19n51tBpWSBHEbsP3z/7aoQ8SnpDb7y8haXYx cQn2f74ogAlPhBq8i6PrImIYK+VqwBk12q/t6S3z5sbM+YVlYUGTNSpPlPlOxr8GWnlc DQbg== Subject: Re: [PATCH 15/15] linux: Remove INTERNAL_SYSCALL_DECL To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-15-adhemerval.zanella@linaro.org> <87v9odmhbc.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Tue, 11 Feb 2020 17:57:54 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87v9odmhbc.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 11/02/2020 09:36, Florian Weimer wrote: > * Adhemerval Zanella: > >> diff --git a/sysdeps/unix/sysv/linux/personality.c b/sysdeps/unix/sysv/linux/personality.c >> index 970bd7becd..d0c597b6a0 100644 >> --- a/sysdeps/unix/sysv/linux/personality.c >> +++ b/sysdeps/unix/sysv/linux/personality.c >> @@ -35,15 +35,14 @@ __personality (unsigned long persona) >> persona = (unsigned int) persona; >> #endif >> >> - INTERNAL_SYSCALL_DECL (err); >> - long ret = INTERNAL_SYSCALL (personality, err, 1, persona); >> + long ret = INTERNAL_SYSCALL_CALL (personality, persona); >> >> /* Starting with kernel commit v2.6.29-6609-g11d06b2, the personality syscall >> never fails. However, 32-bit kernels might flag valid values as errors, so >> we need to reverse the error setting. We can't use the raw result as some >> arches split the return/error values. */ >> - if (__glibc_unlikely (INTERNAL_SYSCALL_ERROR_P (ret, err))) >> - ret = -INTERNAL_SYSCALL_ERRNO (ret, err); >> + if (__glibc_unlikely (INTERNAL_SYSCALL_ERROR_P (ret))) >> + ret = -INTERNAL_SYSCALL_ERRNO (ret); >> return ret; >> } >> weak_alias (__personality, personality) > > The comment is now outdated, I think, and the code should be simplified > in this change (maybe as a separate commit). You could also use long > int instead of long here. > I will check which is current kernel behaviour and check if this comment still holds. I fixed the long use internally.