From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Stefan Liebler <stli@linux.ibm.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3] Add a generic malloc test for MALLOC_ALIGNMENT
Date: Fri, 9 Jul 2021 19:04:53 +0530 [thread overview]
Message-ID: <fac92a89-c19b-f8bf-d238-3af2bf0af435@gotplt.org> (raw)
In-Reply-To: <CAMe9rOoD=9P6waPr3ajUqFOBHTTjc2ns5H5SucmWog38_=H61Q@mail.gmail.com>
On 7/9/21 7:01 PM, H.J. Lu wrote:
> On Fri, Jul 9, 2021 at 6:00 AM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
>>
>> On 7/9/21 5:54 PM, H.J. Lu wrote:
>>> On Thu, Jul 8, 2021 at 9:07 PM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
>>>>
>>>>> diff --git a/malloc/Makefile b/malloc/Makefile
>>>>> index 37a9a4efab..b685ed6d61 100644
>>>>> --- a/malloc/Makefile
>>>>> +++ b/malloc/Makefile
>>>>> @@ -42,6 +42,7 @@ tests := mallocbug tst-malloc tst-valloc tst-calloc tst-obstack \
>>>>> tst-malloc-stats-cancellation \
>>>>> tst-tcfree1 tst-tcfree2 tst-tcfree3 \
>>>>> tst-safe-linking \
>>>>> + tst-mallocalign1 \
>>>>>
>>>>
>>>> Please remove the trailing '\'. OK otherwise.
>>>>
>>>
>>> Changes in the v2 patch
>>>
>>> 1. Add a comment in malloc/tst-mallocalign1.c to indicate that it is
>>> used to verify that MALLOC_ALIGNMENT is honored by malloc.
>>> 2. Include <malloc-alignment.h> in malloc-size.h after SIZE_SZ is
>>> defined since <malloc-alignment.h> may use SIZE_SZ.
>>>
>>> BTW, I kept the trailing '\' since it is used in all other places in
>>> malloc/Makefile.
>>>
>>> OK for master?
>>
>> I forgot to ask, does it run successfully on i686 and arm? IIRC it too
>> requires 16 byte alignment and hence both i686 and x32 will fail.
>
> It fails on i686 and x32.
>
>> If they don't succeed then it may make sense to add
>>
>> tests-exclude-mcheck += tst-mallocalign1
>>
>> for x32 and i686.
>>
>> Siddhesh
>
> Here is the v3 patch to add tst-mallocalign1 to tests-exclude-mcheck
> for i386 and x32.
>
> OK for master?
>
Looks good to me.
Thanks,
Siddhesh
next prev parent reply other threads:[~2021-07-09 13:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 2:35 [PATCH v3 00/10] Remove malloc hooks Siddhesh Poyarekar via Libc-alpha
2021-07-02 2:35 ` [PATCH v3 01/10] mtrace: Deprecate mallwatch and tr_break Siddhesh Poyarekar via Libc-alpha
2021-07-02 2:35 ` [PATCH v3 02/10] Add mcheck tests to malloc Siddhesh Poyarekar via Libc-alpha
2021-07-06 14:50 ` Stefan Liebler via Libc-alpha
2021-07-06 15:54 ` Siddhesh Poyarekar
2021-07-08 23:37 ` H.J. Lu via Libc-alpha
2021-07-09 0:06 ` H.J. Lu via Libc-alpha
2021-07-09 1:46 ` Siddhesh Poyarekar
2021-07-09 3:53 ` [PATCH] Add a generic malloc test for MALLOC_ALIGNMENT H.J. Lu via Libc-alpha
2021-07-09 4:07 ` Siddhesh Poyarekar
2021-07-09 12:24 ` [PATCH v2] " H.J. Lu via Libc-alpha
2021-07-09 13:00 ` Siddhesh Poyarekar
2021-07-09 13:31 ` [PATCH v3] " H.J. Lu via Libc-alpha
2021-07-09 13:34 ` Siddhesh Poyarekar [this message]
2021-07-12 18:02 ` [PATCH v3 02/10] Add mcheck tests to malloc Matheus Castanho via Libc-alpha
2021-07-13 1:06 ` Siddhesh Poyarekar
2021-07-13 12:11 ` Matheus Castanho via Libc-alpha
2021-07-02 2:35 ` [PATCH v3 03/10] Move glibc.malloc.check implementation into its own file Siddhesh Poyarekar via Libc-alpha
2021-07-02 9:05 ` Andreas Schwab
2021-07-02 9:29 ` Siddhesh Poyarekar via Libc-alpha
2021-07-02 9:59 ` Andreas Schwab
2021-07-02 2:35 ` [PATCH v3 04/10] malloc: Move malloc hook references to hooks.c Siddhesh Poyarekar via Libc-alpha
2021-07-02 2:35 ` [PATCH v3 05/10] glibc.malloc.check: Wean away from malloc hooks Siddhesh Poyarekar via Libc-alpha
2021-07-02 2:35 ` [PATCH v3 06/10] mcheck: " Siddhesh Poyarekar via Libc-alpha
2021-07-02 2:35 ` [PATCH v3 07/10] mtrace: " Siddhesh Poyarekar via Libc-alpha
2021-07-02 2:35 ` [PATCH v3 08/10] Remove " Siddhesh Poyarekar via Libc-alpha
2021-07-02 2:35 ` [PATCH v3 09/10] Remove __after_morecore_hook Siddhesh Poyarekar via Libc-alpha
2021-07-02 2:35 ` [PATCH v3 10/10] Remove __morecore and __default_morecore Siddhesh Poyarekar via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fac92a89-c19b-f8bf-d238-3af2bf0af435@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).