From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4176F1F45E for ; Fri, 14 Feb 2020 01:12:43 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=M5jI5JATZaCqujMI S/YxiiQN3uQK28z7VvAuLYJ/FN974KSFph4XHsYqHkIh1AglW2QWkeuHyRjCxi8u 1kCeBvH1QzTDDOyhaZiXGb0LlvlRoHiH/iOeb5gFGa1C9i1ruFKgHDvhyjkSrdds vMu0bMx3aq1StBnbSv2eIU3s2wU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=6gxkRZAtKfVGcsZ5j1lXLg EAJxc=; b=d8fRh+5hzwXBYisnMZAM3lusG2VjynfWTHeSrsNhT+f75XhNLgmTNx qwHf4KpB0TItGAueV5QssjtDIns2D/n3wmXdYRsKOuiHI87/a4PWCqm6X/4zlp9S M1XkcXLpNDj8ZRmRDQhEDfLdODTrE64QES3dFonCD/I36eBO1fMTs= Received: (qmail 76806 invoked by alias); 14 Feb 2020 01:12:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 76797 invoked by uid 89); 14 Feb 2020 01:12:40 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: us-smtp-1.mimecast.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581642757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o5naR7/knhvaeOdeFtivdsF6OMwq0uyqUVN6wFh6pQU=; b=W0qe+O8lADWyHXxTqwF8TgB1PU2aBuCa+ZzpTTN4MwWzZ12B9mvFoa6vRwuP36MKfh5Fh8 nV3N8coiJXnI6/NWfJfzDdE9lRZe7MwWT7vG6VQm/XoYT2DhtNOGJuO11ICBqSdAMXrRFS mUtWAkMxvWccRhNy5XMTYBfS7lRaiS0= Subject: Re: Review promise :-) To: Joseph Myers Cc: GNU C Library References: From: Carlos O'Donell Message-ID: Date: Thu, 13 Feb 2020 20:12:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 2/13/20 3:54 PM, Joseph Myers wrote: > On Thu, 13 Feb 2020, Carlos O'Donell wrote: > >> The hard part is that each developers queue is messy because we don't >> keep them clean. > > One benefit we were supposed to get from stopping manual ChangeLog edits > was that the git-patch-id of a commit for a patch committed with no > changes would match the git-patch-id of the patch posted to the mailing > list - and so patchwork would be able to mark such a patch as committed > automatically. > > I'm not clear if this is a standard patchwork feature or just something we > hoped to be able to implement after stopping manual ChangeLog edits, > however. > > (It might make sense to clean up existing patches in patchwork based on > having a git-patch-id matching a change that is now on master, as well as > doing such cleanup automatically in future.) I think that automating this is the goal with Patchwork 2.0. Right now I'm walking developer patches queues from most recent patch to oldest patch usually looking for something to review. I'm trying to use patchwork in the way it was intended to see what the workflow would look like. -- Cheers, Carlos.