Re: [RFC v2] linux: use __fd_to_filename helper function instead of snprintf.

[Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>]

On 03/05/2021 17:26, Érico Nogueira wrote:
> On Mon May 3, 2021 at 4:26 PM -03, Adhemerval Zanella wrote:
>>
>>
>> On 27/04/2021 10:09, Érico Nogueira via Libc-alpha wrote:
>>> Change made to fchmodat and fexecve. There are tests using xasprintf
>>> instead of this helper as well, but this commit doesn't touch them.
>>
>> To adapt the tests it would require either to build it as
>> internal/static
>> or add fd_to_filename to libsupport. I am not this is really an
>> improvement.
> 
> That might explain some of the build failures I got when I tried
> changing the tests.
> 
>>
>> LGTM, thanks. I will commit this for you.
> 
> Thanks!
> 
> I found a few more places where __fd_to_filename could be used, they are
> currently using _fitoa_word together with stpcpy. Would you be
> interested in making __fd_to_filename use _fitoa_word or _itoa_word? Or
> should it be left as is?

I think it might worth to check whether making __fd_to_filename use
_itoa_word yield any code size gain, but in general it seems a good
refactor.