From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8349E1F8C6 for ; Fri, 9 Jul 2021 14:24:13 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB0F6398CC16 for ; Fri, 9 Jul 2021 14:24:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB0F6398CC16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625840652; bh=Wp9D4ZBVz+/9PxvLL/9ijk4ddbTPHDu+m70P0XfdfDw=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Yz4Nfz8Cg6NRM4m2fnINxZU0db72NJDM09OBZODrOlqCJUpWKXY0TTz6trYIYVdo7 FwvaDvThxToADxLzSVIEPk8SUYChNAE61NxBcmszBEytIWY5cEC1n7vrqoUA3NPxTg hYJ7H/Q7h2F9mYTtIeIBQzLoksV3125DDbrJH8IQ= Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 7501C398CC27 for ; Fri, 9 Jul 2021 14:23:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7501C398CC27 Received: by mail-pj1-x102e.google.com with SMTP id g24so5832446pji.4 for ; Fri, 09 Jul 2021 07:23:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Wp9D4ZBVz+/9PxvLL/9ijk4ddbTPHDu+m70P0XfdfDw=; b=V+gFxAxXwmgZgCBkwOpQ3GcFBIuC8dWZOrcbIZrusR1Pq5OGRKVss/5pQ/zPEC4HKk S0ivIg61H2Y5Q1SKfBNVqaRbKol4mwmP+Bjng75R2Jzm3KX8G9+V7bQx3IfnEPanyrpa F6geQaN8idiWhj9jRF3MXxD/rRC/BOFmYKNjkQKtuSt+SSoeb6/NJFaW9v0ElcXUkIhe JQ0YJzvSfkM+Teb0GnFA3kLCOZthbIrKy8blV+thyxplehVys1z1xBXgGa0o3xvbU4j9 Lqhzi1Xs+tX++G076PdjieC09ugtO3zQthNX9ZjsHu3oHjddTtwD2OZ3J/L6bFD6Nnv6 kQwQ== X-Gm-Message-State: AOAM531jTLTXQiaqFmrP6eZyEnSP86dlmYGtlNfeS2HJ9uRzv3fJ4epE M1x8RLU8o1i+q2+Ipx7QFKat8A== X-Google-Smtp-Source: ABdhPJwd8kgsnBLVym2yvIIobT8UxmpP24pUm5ZalNJU/EFZ/ASM3mDXhCDVzkrraIZOdC2jaL8Nfg== X-Received: by 2002:a17:90a:a617:: with SMTP id c23mr20518714pjq.33.1625840632428; Fri, 09 Jul 2021 07:23:52 -0700 (PDT) Received: from [192.168.1.108] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id c136sm6739654pfc.201.2021.07.09.07.23.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jul 2021 07:23:51 -0700 (PDT) Subject: Re: [PATCH v1 4/6] nptl: Remove mutex test 10 To: Kurt Kanzenbach , libc-alpha@sourceware.org References: <20210625081104.1134598-1-kurt@linutronix.de> <20210625081104.1134598-5-kurt@linutronix.de> Message-ID: Date: Fri, 9 Jul 2021 11:23:48 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210625081104.1134598-5-kurt@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Cc: Florian Weimer , Sebastian Andrzej Siewior , Peter Zijlstra , Thomas Gleixner , Joseph Myers Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 25/06/2021 05:11, Kurt Kanzenbach wrote: > That test checks whether pthread_mutex_clocklock(MONOTONIC)/PI returns EINVAL. > > However, support for that has been implemented. Therefore, remove the test. > > Signed-off-by: Kurt Kanzenbach I think the patch should be kept, but change to FAIL_UNSUPPORTED if the *first* call return EINVAL and trigger a real failure if first type success but subsequent types returns EINVAL. > --- > nptl/Makefile | 2 +- > nptl/tst-mutexpi10.c | 68 -------------------------------------------- > 2 files changed, 1 insertion(+), 69 deletions(-) > delete mode 100644 nptl/tst-mutexpi10.c > > diff --git a/nptl/Makefile b/nptl/Makefile > index c64e4af2f680..5ab25c524fac 100644 > --- a/nptl/Makefile > +++ b/nptl/Makefile > @@ -269,7 +269,7 @@ tests = tst-attr2 tst-attr3 tst-default-attr \ > tst-mutex5a tst-mutex7a \ > tst-mutexpi1 tst-mutexpi2 tst-mutexpi3 tst-mutexpi4 \ > tst-mutexpi5 tst-mutexpi5a tst-mutexpi6 tst-mutexpi7 tst-mutexpi7a \ > - tst-mutexpi9 tst-mutexpi10 \ > + tst-mutexpi9 \ > tst-cond22 tst-cond26 \ > tst-robustpi1 tst-robustpi2 tst-robustpi3 tst-robustpi4 tst-robustpi5 \ > tst-robustpi6 tst-robustpi7 tst-robustpi9 \ > diff --git a/nptl/tst-mutexpi10.c b/nptl/tst-mutexpi10.c > deleted file mode 100644 > index da781d0d7a93..000000000000 > --- a/nptl/tst-mutexpi10.c > +++ /dev/null > @@ -1,68 +0,0 @@ > -/* Check if pthread_mutex_clocklock with PRIO_INHERIT fails with clock > - different than CLOCK_REALTIME. > - Copyright (C) 2020-2021 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, see > - . */ > - > -#include > -#include > -#include > - > -#include > -#include > -#include > - > -static int > -do_test (void) > -{ > - const int types[] = { > - PTHREAD_MUTEX_NORMAL, > - PTHREAD_MUTEX_ERRORCHECK, > - PTHREAD_MUTEX_RECURSIVE, > - PTHREAD_MUTEX_ADAPTIVE_NP > - }; > - const int robust[] = { > - PTHREAD_MUTEX_STALLED, > - PTHREAD_MUTEX_ROBUST > - }; > - > - > - for (int t = 0; t < array_length (types); t++) > - for (int r = 0; r < array_length (robust); r++) > - { > - pthread_mutexattr_t attr; > - > - xpthread_mutexattr_init (&attr); > - xpthread_mutexattr_setprotocol (&attr, PTHREAD_PRIO_INHERIT); > - xpthread_mutexattr_settype (&attr, types[t]); > - xpthread_mutexattr_setrobust (&attr, robust[r]); > - > - pthread_mutex_t mtx; > - xpthread_mutex_init (&mtx, &attr); > - > - struct timespec tmo = timespec_add (xclock_now (CLOCK_MONOTONIC), > - make_timespec (0, 100000000)); > - > - TEST_COMPARE (pthread_mutex_clocklock (&mtx, CLOCK_MONOTONIC, &tmo), > - EINVAL); > - > - xpthread_mutex_destroy (&mtx); > - } > - > - return 0; > -} > - > -#include >