From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 9C0FF1F45E for ; Tue, 11 Feb 2020 21:01:31 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=aMqxBHZg50KBv8FP 5BjOFuZfFxr5nhjKSxteI6BO9zyZHgl++lmLfI8nypZQhY4xix7od2DkYJK1xG4j 9YogHX1j/qz/3v4/kgDmDCA55vKE6dMxwgeXq/slipjA+0opjhKOe4mTq8YyRfnu BvNIGe76no3O/h1ezRDp+wo7uxI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=o9oWbENjmvK1ATTW+UiibW 4Emys=; b=UbMXjiykbVn5Kb3WgOMYLTNqsDtA97v5RyAfYYB4ZeAqyqwU9bc5Ul Jp/wKGIgsAPw2nND+c54GH+OdS2lT7W9hVwFp+pTH2uZnpADtQly7fE0caszvx2s SaxLz7DBKqYB/e/NBOafcmREXUY2guDQAgm5iEbqTWO8a+WFQyvqs= Received: (qmail 129802 invoked by alias); 11 Feb 2020 21:01:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 129793 invoked by uid 89); 11 Feb 2020 21:01:29 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7s/n1aRXfXov9ZVao99tZXu0276g7SV72c/1w4jPGPk=; b=RNiaAHJTsM+NdtHs75DT3GX+PSWBXZPpkoZjg9fsM1FKR7W6WhT3CpOmtZkH4LJdEN FnjIW4qWbQoIRNtv94wcMsfH3b3ibClaTuGJpauXNuUSFIKe/esyB3Pee0IrFBjCSG79 daem6ebciBW1n2TsW6mcUB2i2ID+R051dFgqt/hkIvR3+6q6UUAS1fhkbSQFhpJDV2/3 8os84R8IwKfrCuLSsjDWp5lLUY64GPJdNX1zWl69OoEJhWWObwb72TGISooh8neUfy8E MA6P3YMMfggdgx/EIhWEaRZENaCfSUAqqJXWonNtWqcvN53zfwpMY68rlXxZ0009PzgX s6Hw== Subject: Re: [PATCH 14/15] nptl: Remove ununsed pthread-errnos.h rule To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-14-adhemerval.zanella@linaro.org> <87mu9pnz91.fsf@oldenburg2.str.redhat.com> <87imkdnxzp.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Tue, 11 Feb 2020 18:01:22 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87imkdnxzp.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 11/02/2020 08:51, Florian Weimer wrote: > * Florian Weimer: > >> * Adhemerval Zanella: >> >>> --- >>> nptl/Makefile | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/nptl/Makefile b/nptl/Makefile >>> index 6f210d60e3..fcdc72adfe 100644 >>> --- a/nptl/Makefile >>> +++ b/nptl/Makefile >>> @@ -327,8 +327,7 @@ test-xfail-tst-once5 = yes >>> # Files which must not be linked with libpthread. >>> tests-nolibpthread = tst-unload >>> >>> -gen-as-const-headers = pthread-errnos.sym \ >>> - unwindbuf.sym \ >>> +gen-as-const-headers = unwindbuf.sym \ >>> pthread-pi-defines.sym >>> >>> gen-py-const-headers := nptl_lock_constants.pysym >> >> I don't think this is unused? > > Sorry, I see the changes now. But why doesn't this patch delete the > pthread-errnos.sym file as well? I update the patch to delete it, thanks for catching it.