From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0C3281F466 for ; Mon, 20 Jan 2020 18:52:51 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=Y2feltB0DJxlCpmT B4eU6FF0WK8wS8t4mSdKVAHkkdi2Cq8AOMP3GWvRm259c8WPqJnXaIIZoUsFPTGf BSMd+I10Io+J2F2TSG2IHcLXYOTmTW2P7KIAM9OKAm8d0tvK+UhYpITca39o9SK4 p1RXvoHq6f2ha1Rn52Y2Hinn3e0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=msq7AeNH9PgkckBs2GFmen VKz6M=; b=CyQHAXn/BHlt3hGnLg3q6mG5SKkUrRyZCNLr6T5vAP7PCL2R+KJaZP FePcwLCJjU8DtzjQIeOgBaobUe5mNBmWmE/X8c8gQ4Hzek5VjhBy01ekOkqf5b30 CTINGc+B54OmWfAI7p1aCYm346qQLDpHeSMczh7DQJ6fbdhvEzh+I= Received: (qmail 119678 invoked by alias); 20 Jan 2020 18:52:48 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 119668 invoked by uid 89); 20 Jan 2020 18:52:48 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qt1-f196.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=m5XYcf1lwCPOdNZiTvB13/qqX0vtefv8p57d/FLcQtA=; b=FF5e1aT+n46BCF/KiJ1B+lcTw8qPH2Lq22YYUcfJiPhMgIjY4BJ4yKW7aSDrlP76ez Q7zyzCbVHDCbp0qOtA7LcZ900LYtGeQPo4NdLiY/x79S427riA3HObxlUYFOQr5Wz5d4 GeDTf2NpOFxVIegLIxDHg8weNSWd/nXrz+2/oHpttAM93f7scuN9ayknkjIQo6YsK93q QiSwZOHfQdTRdqN64f2broFW72ac9wykL/xy3XT9F628KXpzzFJDGYYNAR3zgqejaMGh MPBytKRSj6VERifEarG8lLP71jFZV9HcXy+5iqydMKGLyRL78Tea2H35px/cAZDQnqyY 3UyQ== Subject: Re: [PATCH 07/10] C11 threads: Fix thrd_t / pthread_t compatibility assertion To: libc-alpha@sourceware.org References: <20200114185255.25813-1-samuel.thibault@ens-lyon.org> <20200114185255.25813-9-samuel.thibault@ens-lyon.org> From: Adhemerval Zanella Message-ID: Date: Mon, 20 Jan 2020 15:52:33 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200114185255.25813-9-samuel.thibault@ens-lyon.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit LGTM with a small nit below. Reviewed-by: Adhemerval Zanella On 14/01/2020 15:52, Samuel Thibault wrote: > --- > nptl/thrd_create.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/nptl/thrd_create.c b/nptl/thrd_create.c > index 8474e234c9..fe08e22973 100644 > --- a/nptl/thrd_create.c > +++ b/nptl/thrd_create.c > @@ -21,8 +21,8 @@ > int > thrd_create (thrd_t *thr, thrd_start_t func, void *arg) > { > - _Static_assert (sizeof (thr) == sizeof (pthread_t), > - "sizeof (thr) != sizeof (pthread_t)"); > + _Static_assert (sizeof (*thr) == sizeof (pthread_t), > + "sizeof (*thr) != sizeof (pthread_t)"); > > int err_code = __pthread_create_2_1 (thr, ATTR_C11_THREAD, > (void* (*) (void*))func, arg); > I think it is better to use the type direct as other C11 implementation, _Static_assert (sizeof (thrd_t) == sizeof (pthread_t), ...).