From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-5.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 089DF1F670 for ; Tue, 19 Oct 2021 16:27:09 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F2F673858432 for ; Tue, 19 Oct 2021 16:27:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F2F673858432 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1634660828; bh=Iip/OPLMUgI6XDee1kUgrHeyq1q9BwUY6xIcOgTjO/w=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=C+EE6+QwSJEWJutqagxOHTc/pE8M9GzndGhz+f8J7zfycdo2qoxTKX9gko45KRSlN z5Z/WQnFkTpLZxIeko7DSDBjBOxREvC8E4DoRSF1XOYcaE6b4cQtZyQozPzFVzCIqZ IkcGvgQZPXnQyZqGW9vrPdA3wZTxtscjWVA9dAEc= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id 9E3E43858D39 for ; Tue, 19 Oct 2021 16:26:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9E3E43858D39 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-501-4c5o7WLrPD6NZnpDfS6dHQ-1; Tue, 19 Oct 2021 12:26:46 -0400 X-MC-Unique: 4c5o7WLrPD6NZnpDfS6dHQ-1 Received: by mail-qk1-f200.google.com with SMTP id b189-20020a3799c6000000b0045eb0c29072so318439qke.12 for ; Tue, 19 Oct 2021 09:26:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=Iip/OPLMUgI6XDee1kUgrHeyq1q9BwUY6xIcOgTjO/w=; b=zVdrcQhARFM66CIgi3uArbXTrTKnrBAen2YYNEdSXp9oH7hsfWMoMDh6OcEM6HStNe qK2DReoXCjG22ReHsB/ntF5NpzIzx+xZUSbTwXybWvCmUHq1Z/+mqQ5a83r570lcol8p KBbGfEgsbhWq8Hj9hOdW5R9WjKrFhK2ur9GSeUwD2ajD472Z+6TdDGlbyY+BgGZfCMuN 78/B1f5m07LDt1mlxJL1sFjx8sUb1MSIMBG03hANa6nx4O0jcVd51xN4lV435ANTPFZW 9h0fI/m2RMpiaoY2KG+V41QNeskDEYzOtxAgRczrpr+hnJXtCY9QnXt7AaiRQnWP6dt6 HFcA== X-Gm-Message-State: AOAM530+LEWUj3LoIa6UKqrDvHbgkEuvppi6PQz5ANdtz9pZldmVV1+3 rcVAuaJg5/34riYKtuKTJeeV2UvZ7XmFLwzbZmmG5W7paWF7VG0Ri88jHIAwatcKCJUM3cB/KKQ 190e0juo/fQghNF/rfQyM X-Received: by 2002:ac8:4b52:: with SMTP id e18mr1028772qts.213.1634660804975; Tue, 19 Oct 2021 09:26:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyO4uIq3Qswwo5u3guNR1DQwWccSvkoed/ref8D+laFYiDq9bQxz9qP/K0LmHhD8ygT6B0AAQ== X-Received: by 2002:ac8:4b52:: with SMTP id e18mr1028748qts.213.1634660804750; Tue, 19 Oct 2021 09:26:44 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id a5sm7613991qtd.52.2021.10.19.09.26.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Oct 2021 09:26:44 -0700 (PDT) Message-ID: Date: Tue, 19 Oct 2021 12:26:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: avoid -Waddress in vfprintf-internal.c To: Martin Sebor , Florian Weimer , Martin Sebor via Libc-alpha References: <14db3354-56a5-86cc-b840-010c9ba7fc83@gmail.com> <87ilymgmd4.fsf@oldenburg.str.redhat.com> <05f35752-1d06-72ae-85bc-28ad2365b1c6@gmail.com> Organization: Red Hat In-Reply-To: <05f35752-1d06-72ae-85bc-28ad2365b1c6@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 9/27/21 19:58, Martin Sebor via Libc-alpha wrote: > On 9/27/21 7:48 AM, Florian Weimer wrote: >> * Martin Sebor via Libc-alpha: >> >>> Building Glibc with a GCC 12 enhanced to detect more instances >>> of comparing addresses to null that are guaranteed to evaluate >>> to a constanst triggers a large number of such instancesl. >>> The warnings, all isolated to the same file, are valid and >>> intended but the Glibc code is safe.  They show up because >>> the comparison is in a macro to which either null or a constant >>> address of an array element are alternately passed as an argument. >>> >>> The attached patch avoids these warnings by introducing local >>> variables for the address being compared (an array element) >>> as well as for the null pointer. >>> >>> Tested by building Glibc on x86_64, verifying the warnings >>> are gone, and by running the testsuite and checking for new >>> failures. >> >> I believe the issue addressed in this patch no longer exists in current >> Git.  Would you please verify? > > I don't see the warnings in my latest build anymore.  The GCC patch > that enhances the warning is still waiting for formal approval but > I don't expect to make any substantive changes to it.  I've resolved > the bug I raised to keep track of the warnings (BZ #28368). Is this patch still required for any other reasons? -- Cheers, Carlos.