From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7AC2E1F4B4 for ; Wed, 20 Jan 2021 08:56:24 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B2DCB394BE2C; Wed, 20 Jan 2021 08:56:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2DCB394BE2C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611132982; bh=oz4Z2hUCFoHZY1GHHxph7m+EiSKjLPPU4J1oFyiqquA=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=t8k2W/nHDvKIPDKm5lYQAy6OQVIL6DeKTVAvSTlEcXg6pGzbFc4RAtkLHfDEMpKNN oI1D1QRYy5iFqoCquwyTqZxgMBnWtgZYSMsS2e43M49/+VoUFxui/OLWVAQ32Qy589 /AKgLH+xLvS2nMyAacTNRFyv664zkAD/E8eTx3gA= Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id A794A3840C1B for ; Wed, 20 Jan 2021 08:56:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A794A3840C1B Received: by mail-wr1-x42d.google.com with SMTP id m4so22247565wrx.9 for ; Wed, 20 Jan 2021 00:56:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oz4Z2hUCFoHZY1GHHxph7m+EiSKjLPPU4J1oFyiqquA=; b=rhyvtk4rlsQHmZjyyIAYrjwxrRPTwGow9PfzI33ulPl657g/xD2X/2tvVOueqPiAUE IbEL/z2HPtsLEgZ5uFSeb1DKU8RMoIgOTl/hY7Po8L4U0AoJelKRJcgvB8OimWJwUSzg 6utAgiOrqD/z7b4PWzeNK1TJ6S8k3gaEJmVNc5WlufBXmHF2YN9ZwEabhSiJr/vlDQaw 9ymEBmeojrPWDGrx9oDR7gHVGWajLiJ4u+cSYCDRV9saD+WSTELuRi38Y76DUzQFKKa0 xvuVN7dlp2aRykpi7MlapQ1PcCP+c09hfyRo8CqVD9kOOkg0BAplG+c11PumyzNjhu5P Uu8A== X-Gm-Message-State: AOAM5327ZBOekpwt0eMMi0/Zc3ogrNGNPMZ8ODVWK0we5O4TZkiKeX+f jhsaGgORSCh3aYCgbPRAMP3V0SDlEUc= X-Google-Smtp-Source: ABdhPJwif15rVPovOMYK0B8l3/jnJEqInigaT22rVRvZTHXfTerKdTT8kvBljC66eQuf2ysxr8ez8g== X-Received: by 2002:a5d:6a4c:: with SMTP id t12mr8164439wrw.249.1611132979585; Wed, 20 Jan 2021 00:56:19 -0800 (PST) Received: from ?IPv6:2a02:2455:e0:e000:3005:efab:c884:ced0? ([2a02:2455:e0:e000:3005:efab:c884:ced0]) by smtp.gmail.com with ESMTPSA id b3sm2591159wme.32.2021.01.20.00.56.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 00:56:18 -0800 (PST) Subject: Re: [PATCH] circleq.3: Fix CIRCLEQ_LOOP_*() return type To: Alejandro Colomar References: <20210119211226.440430-1-alx.manpages@gmail.com> Message-ID: Date: Wed, 20 Jan 2021 09:56:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210119211226.440430-1-alx.manpages@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Michael Kerrisk \(man-pages\) via Libc-alpha" Reply-To: "Michael Kerrisk \(man-pages\)" Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org, mtk.manpages@gmail.com Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Hi Alex, On 1/19/21 10:12 PM, Alejandro Colomar wrote: > Signed-off-by: Alejandro Colomar > --- > man3/circleq.3 | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) Thanks. Patch applied. Cheers, Michael > diff --git a/man3/circleq.3 b/man3/circleq.3 > index 6b6b9aa14..f21bbf903 100644 > --- a/man3/circleq.3 > +++ b/man3/circleq.3 > @@ -75,9 +75,9 @@ CIRCLEQ_REMOVE > .BI "struct TYPE *CIRCLEQ_LAST(CIRCLEQ_HEAD *" head ); > .BI "struct TYPE *CIRCLEQ_PREV(struct TYPE *" elm ", CIRCLEQ_ENTRY " NAME ); > .BI "struct TYPE *CIRCLEQ_NEXT(struct TYPE *" elm ", CIRCLEQ_ENTRY " NAME ); > -.BI "void CIRCLEQ_LOOP_PREV(CIRCLEQ_HEAD *" head , > +.BI "struct TYPE *CIRCLEQ_LOOP_PREV(CIRCLEQ_HEAD *" head , > .BI " struct TYPE *" elm ", CIRCLEQ_ENTRY " NAME ); > -.BI "void CIRCLEQ_LOOP_NEXT(CIRCLEQ_HEAD *" head , > +.BI "struct TYPE *CIRCLEQ_LOOP_NEXT(CIRCLEQ_HEAD *" head , > .BI " struct TYPE *" elm ", CIRCLEQ_ENTRY " NAME ); > .PP > .BI "CIRCLEQ_FOREACH(struct TYPE *" var ", CIRCLEQ_HEAD *" head , > @@ -238,13 +238,23 @@ and zero if the queue contains at least one entry. > .PP > .BR CIRCLEQ_FIRST (), > .BR CIRCLEQ_LAST (), > -.BR CIRCLEQ_PREV (), > +.BR CIRCLEQ_LOOP_PREV (), > and > -.BR CIRCLEQ_NEXT () > +.BR CIRCLEQ_LOOP_NEXT () > return a pointer to the first, last, previous, or next > .I TYPE > structure, respectively. > .PP > +.BR CIRCLEQ_PREV (), > +and > +.BR CIRCLEQ_NEXT () > +are similar to their > +.BR CIRCLEQ_LOOP_* () > +counterparts, > +except that if the argument is the first or last element, respectively, > +they return > +.IR &head . > +.PP > .BR CIRCLEQ_HEAD_INITIALIZER () > returns an initializer that can be assigned to the queue > .IR head . > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/