From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id D14711F4B4 for ; Thu, 1 Oct 2020 14:49:51 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BE58B386197F; Thu, 1 Oct 2020 14:49:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE58B386197F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1601563790; bh=TskYAFoayHSxwQ32vKcPqnSvwkNvRX0jfjPJh+sUCQE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=nmyGfw7eNcZ74L/NwQ0xZILVtPq+cqmfx4oiTgWgcshZ/gkawK/Rgz7jBB6mSxy8P 9YokX7pyOmv/FSWVcuOmcAamnzoHmFcTNzA0yjTgdCRXssKfXOiC462dr0Jbr04jcW zFerBw4KXn/+/xiKLuhrkaTWiuj+YM3nrFfX7V5Q= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 406A1385703A for ; Thu, 1 Oct 2020 14:49:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 406A1385703A Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-549-6HXl_DJfNau5ThNXkq8B3A-1; Thu, 01 Oct 2020 10:49:45 -0400 X-MC-Unique: 6HXl_DJfNau5ThNXkq8B3A-1 Received: by mail-qk1-f197.google.com with SMTP id h191so3194694qke.1 for ; Thu, 01 Oct 2020 07:49:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=TskYAFoayHSxwQ32vKcPqnSvwkNvRX0jfjPJh+sUCQE=; b=YZ71W6/tYxwf6pLuFBou7CLZn7LH4q9U1Ble+N2v9/NSW2A9u4eNXLq1B3xyVtJ70x 7yW6oqLD6qQ7DpNS8adgthV/IXvoZKTn20JE1pim5XLYEb5mtSAJSHtYN9N94jpdqanR 6pWd9r4baOIFgWFWZjryX7aY35O5sQXXx/4auq+zJebXURgV7ZoEsGSUvktR2DtBN1e/ UbJcT5gE6UEvbAAvghQvgyCkucNXdwKdtsoO3kl9Quvn8DSXOPpz29U7MZaiSqTMEMbH SxWf+Mc/o7R2iVrn7JOnPhRrnJmZkSyRy3VFNIy48C78cZX5BNwykpQf/iFdIWaymEnN jgQw== X-Gm-Message-State: AOAM530sNdrmy1a/HFj3Qf2SefmHNE2oMDmlKZNwtRxgKy4xy8XlQ7ke QbPRHJdjAzEQUrCd+x8HS2glDoqu8td9ry5dQPDp499E+z6tn/db0JWQG7l/G1gXegjv5NFMVMT 1aP1rFcx66aFLgPTe7B6D X-Received: by 2002:a05:620a:c90:: with SMTP id q16mr8075987qki.194.1601563785038; Thu, 01 Oct 2020 07:49:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCBrsrtEvufxZEz7zMiwLaxtJax6bCwWA0KKevIqCxXqgFqi6V4f6SFK3K7Sxgky0eO1wD7g== X-Received: by 2002:a05:620a:c90:: with SMTP id q16mr8075962qki.194.1601563784718; Thu, 01 Oct 2020 07:49:44 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id g19sm6115678qka.84.2020.10.01.07.49.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2020 07:49:43 -0700 (PDT) Subject: Re: [PATCH] Make abort() AS-safe (Bug 26275). To: Florian Weimer , Rich Felker References: <20200927141952.121047-1-carlos@redhat.com> <871rinm1fx.fsf@mid.deneb.enyo.de> <20200928234833.GC17637@brightrain.aerifal.cx> <87d025jcn0.fsf@mid.deneb.enyo.de> <20200929144207.GD17637@brightrain.aerifal.cx> <20201001023018.GL17637@brightrain.aerifal.cx> <87o8lmeaw7.fsf@mid.deneb.enyo.de> Organization: Red Hat Message-ID: Date: Thu, 1 Oct 2020 10:49:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87o8lmeaw7.fsf@mid.deneb.enyo.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Cc: Carlos O'Donell via Libc-alpha , musl@lists.openwall.com Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 10/1/20 2:08 AM, Florian Weimer wrote: > * Rich Felker: > >> Even without fork, execve and posix_spawn can also see the SIGABRT >> disposition change made by abort(), passing it on to a process that >> should have started with a disposition of SIG_IGN if you hit exactly >> the wrong spot in the race. > > My feeling is that it's not worth bothering with this kind of leakage. > We've had this bug forever in glibc, and no one has complained about > it. > > Carlos is investigating removal of the abort lock from glibc, I think. I am investigating the removal, but I think the replacement solution might be needing to have a helper thread carry out specific tasks. Like Rich I'm still a little worried about the other cases that the lock is intended to fix. -- Cheers, Carlos.