From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8DB051F44D for ; Wed, 27 Mar 2024 19:05:45 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ogagd5ZA; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C28BC3858C36 for ; Wed, 27 Mar 2024 19:05:44 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 504AF3858407 for ; Wed, 27 Mar 2024 19:05:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 504AF3858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 504AF3858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711566323; cv=none; b=Ooyb6nPYCY2nkq1qVxWu/uSI0nOkjXx9qodepQQmDmsi4BM1Z+ZThR+WN4gbmzledsYSEIIZr6gE8kk+9blLa7ttTNF+4JSDeiO6ADqL2dUeiCUAugOia2K9PnQ34i+o+yFc+LgAQpeZqUvn1HO48wkVj5TcTizmhsVe/7ktNlE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711566323; c=relaxed/simple; bh=FMtnfEHOFv2ZHzWkYWWDeDOy35mnOwmCbz/HMzSZ48w=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=dyCuyggSd9ieTggm+GA2buhY9y2Bv0Wqc29LM1KYAy2DxqhGDH5xFpZ9TYc8GbYt80/NzfWIyVAzK9v9X+EcOFpuAc5V1bilQPoDDcC5ESudlQWvoeCaZsl5Hk7wdc95p4XhL/WJp8YlBthzboBU39I0ZK3sTKDAtGhGPv9PqaM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711566312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EQaejQwuSkPG/GXKHHfFkiCB2629qSLax2I4/2+zTaM=; b=Ogagd5ZApB+ViB4KiyzZRzRlUx3QBUDzHSPwErS2vXX/8btbYSMBpoW14PgRq/A5mfK4im uXNKO94cuFvsWkI58mkBs4kKcXrMsOPBKN9NsM9ddL1xc0eDJCyUIGd+6MeJQPIhVatL+u grf4VSUJ49/ofOsKhw5DBqtbmL8TqS4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-emiIvKnxPjCUzLudny-Qiw-1; Wed, 27 Mar 2024 15:05:11 -0400 X-MC-Unique: emiIvKnxPjCUzLudny-Qiw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4147ddecd52so1058975e9.0 for ; Wed, 27 Mar 2024 12:05:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711566310; x=1712171110; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EQaejQwuSkPG/GXKHHfFkiCB2629qSLax2I4/2+zTaM=; b=DmOYxLJtGLfMW23YuPDaaYuu7xHccVx0zSm6ggFWTPTvx/GwusbT+AioG5Tu+UdWVw S9iRDgmismjPRJoAWSkwgM6+iPUdmEkM526X57imIo95Od+OKe49n6MCes/mFsMs5TbH laa16226PcPi4Q4mn0AmRPPcl4mVsmtowEshAmwp2rviY0qCwnUpFBB4cnqxr8PVcsGu ZpRgArvdV/+kfvDCDV0i3E7yEO7+d1+yDwdrv52jUvLXAylo29/4kXHjj183RrqY6lI+ blPMVb16YQ7R1LykDkvB1pcsNWEwT1YIS4d0JXempJafTWYpCGVYC/e9Lido8kN0iIIs tdUQ== X-Gm-Message-State: AOJu0YxQMv1g/oz9U8VAMpWA0EtCn6uO6RKUrQbapWQJcOKKiPWpzXFI EVzxIkB8SUy8jzVThKwL+WyfyrAiAOijrkXDjauJbhxQ91mbqyYVW+wGAAkKt+dIhN6QRUYpwjs wVKL4WYnvujDypLcPqnA6j2b2tSb/ruLWOi0IMI2uXjscTWzStCN2txsvsQ== X-Received: by 2002:a05:600c:19cc:b0:414:7bf0:973f with SMTP id u12-20020a05600c19cc00b004147bf0973fmr134342wmq.9.1711566310205; Wed, 27 Mar 2024 12:05:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHcPjTMiOyQUA3M0Ub2zbtSilsmdgx3fKWGqItG5eqg17tDMTWmsPTe4Fg9BUc15ar2NmkpQg== X-Received: by 2002:a05:600c:19cc:b0:414:7bf0:973f with SMTP id u12-20020a05600c19cc00b004147bf0973fmr134323wmq.9.1711566309805; Wed, 27 Mar 2024 12:05:09 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id hg14-20020a05600c538e00b004147b5dd6f8sm2980293wmb.9.2024.03.27.12.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 12:05:09 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rpYZd-0011yJ-0i; Wed, 27 Mar 2024 19:04:33 +0000 Date: Wed, 27 Mar 2024 19:04:33 +0000 (UTC) From: Joseph Myers To: Adhemerval Zanella Netto cc: libc-alpha@sourceware.org, Florian Weimer , "H . J . Lu" Subject: Re: [PATCH 11/15] math: Fix acos template for arguments greater than 1 In-Reply-To: <21a70abc-787c-403d-bf3d-24e386be8a7e@linaro.org> Message-ID: References: <20240327164527.3717523-1-adhemerval.zanella@linaro.org> <20240327164527.3717523-12-adhemerval.zanella@linaro.org> <21a70abc-787c-403d-bf3d-24e386be8a7e@linaro.org> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On Wed, 27 Mar 2024, Adhemerval Zanella Netto wrote: > And I think it is unrelated to gcc PR95115 because x86_64/i686 will use > and specific sysdeps/i386/fpu/e_acosl.c that explicit does not handle this > input case for overflow exceptions. For shared build this case is > handle by w_acosl_compat.c: > > if (__builtin_expect (isgreater (fabsl (x), 1.0L), 0) > && _LIB_VERSION != _IEEE_) > { > /* acos(|x|>1) */ > feraiseexcept (FE_INVALID); > return __kernel_standard_l (x, x, 201); > } The compat code is dealing with the possibility of SVID exceptions, which isn't relevant here. > And that's why I though following the same logic on template would be > better. But I think maybe we should fix on x86_64 implementation instead. Yes, we should fix the x86_64 implementation. Such issues in dbl-64, flt-32 or ldbl-128 sources would largely have been fixed (modulo compiler bugs) when we started adding new architectures after new architectures stopped using the compat wrappers - but any issues for ldbl-128ibm, ldbl-96 or architecture-specific sources wouldn't have been detected then. -- Joseph S. Myers josmyers@redhat.com