From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 58DE81F5AE for ; Fri, 24 Jul 2020 20:40:08 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 91BD63857C61; Fri, 24 Jul 2020 20:40:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91BD63857C61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1595623207; bh=tuafUbyZz+95mV0L/+VWROyJFN1FBPESX9AiXIEMXpQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xciPmyyWcw5M+oy2wLfZgN6U8nYvRoME7BAzPO2V8m7LqFKy3vYnTVD3l5TDmD/Tw 7xfLJQ1E4FLYPwkQc3GnwqjdN2QBWA+BIdxIl1zGgsESpSDdLVK46uyJ61/3jWf7Dt cWZ6GxmIPPdRZOef2wPAR0Khj9+6uVbKpDb3YTgg= Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 3D4733857C41 for ; Fri, 24 Jul 2020 20:40:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3D4733857C41 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-1oVbV9xaOliLfo2g6osYsg-1; Fri, 24 Jul 2020 16:40:03 -0400 X-MC-Unique: 1oVbV9xaOliLfo2g6osYsg-1 Received: by mail-qk1-f200.google.com with SMTP id q18so3876821qkq.11 for ; Fri, 24 Jul 2020 13:40:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=tuafUbyZz+95mV0L/+VWROyJFN1FBPESX9AiXIEMXpQ=; b=ubJNIly0VMjs0YjEYwLS0+Si9UW3MhLHckXWiBhNZQJUxXraCPjneqMMClQCvnu5Ef MJA5eQJuXxJBzMf0i713IQNmlm4N/GpKbWMKlAsmon65QYZEynF7O4O+EQ7ZuPp0NPf/ e3lE2tnQ+ZiJSLUEVO1wkJ3Kj5QIr5UG/l1avKTCyNWTZgakQgJ8f3SPfsSBg3qllV+E ny7f7Kt/0g0TSWDifKKhyQZhiMyCejZYqp/7y0ns1Y4uXBtlVcayTfFmMjcG6SDKygyD wX2IhwHE3XgJhZRb7wm4NlUdCHPsJKSJ9UHVsXDn2fmJgxtjj+t9ti9Zti20Et+UNN// VztQ== X-Gm-Message-State: AOAM530+C1hbLslf5M+hsw1daE+JAFGMeJy3iQyJbz8p/fs5RF3vXVHh kU1Rz/GPmvDs7wNkVh+/K6z65vskcRTStprcBImBE18+40DaTtfDS4UVwE0d5fFbbzAEZe/ZN38 3SeJ6MjPxMyJFpFyKXbNp X-Received: by 2002:a0c:9e52:: with SMTP id z18mr11275083qve.59.1595623202630; Fri, 24 Jul 2020 13:40:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRrinbzIPFrGIZWrvwQvZpiprRt5rXKeOWzctqOKVe9VcKntMMlgG/faisbvD7aqu1zI5MIQ== X-Received: by 2002:a0c:9e52:: with SMTP id z18mr11275071qve.59.1595623202423; Fri, 24 Jul 2020 13:40:02 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id j16sm5020269qke.87.2020.07.24.13.40.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2020 13:40:01 -0700 (PDT) Subject: Re: [PATCH] NEWS: Deprecate weak libpthread symbols for single-threaded checks To: Adhemerval Zanella , libc-alpha@sourceware.org References: <875zad7yrc.fsf@oldenburg2.str.redhat.com> Organization: Red Hat Message-ID: Date: Fri, 24 Jul 2020 16:40:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 7/24/20 12:36 PM, Adhemerval Zanella via Libc-alpha wrote: > > > On 24/07/2020 11:50, Florian Weimer via Libc-alpha wrote: >> Recommend the new __libc_single_thread variable instead. >> >> --- >> NEWS | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/NEWS b/NEWS >> index 83aed60e19..7fb167e650 100644 >> --- a/NEWS >> +++ b/NEWS >> @@ -134,6 +134,14 @@ Deprecated and removed features, and other changes affecting compatibility: >> or contents might be overwritten on subsequent calls in the same thread or >> if the thread is terminated. It makes strerror MT-safe. >> >> +* Using weak references to libpthread functions such as pthread_create >> + or pthread_key_create to detect the singled-threaded nature of a >> + program is an obsolescent feature. Future versions of glibc will >> + define pthread_create within libc.so.6 itself, so such checks will >> + always flag the program as multi-threaded. Applications should check >> + the __libc_single_threaded variable declared in >> + instead. >> + >> * The "files" NSS module no longer supports the "key" database (used for >> secure RPC). The contents of the /etc/publickey file will be ignored, >> regardless of the settings in /etc/nsswitch.conf. (This method of >> > > Should we add it on the 'Major features' instead along with the single-threaded > entry? No, it's good to call it out in the deprecated features. People might only be looking at one or the other so we should have an entry in both. -- Cheers, Carlos.