On 12/30/20 12:15 PM, Adhemerval Zanella wrote: > - ssize_t level; > + size_t level; 'level' should be ptrdiff_t not ssize_t, for portability to (now-ancient, but still allowed by POSIX) hosts where ssize_t is 32 bits and size_t is 64 bits. > - CHAR str[]; > + CHAR str[FLEXIBLE_ARRAY_MEMBER]; This assumes C99 flex array members which is fine for glibc but dubious for Gnulib; it should be safer to use __flexarr. > Because otherwise it triggers some glibc regressions: Thanks for spotting that. I installed the attached patch into Gnulib, which should fix the glibc regressions and the other abovementioned glitches, so that you should now be able to sync fnmatch from Gnulib unchanged.