From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3FCC21F403 for ; Thu, 20 Oct 2022 18:13:01 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="oycxdeYz"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 53B8C384D15C for ; Thu, 20 Oct 2022 18:12:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 53B8C384D15C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666289578; bh=7hIq2qxDJMng+ZQtN/hmgTEU8TKHZocaZInHiZ0EvGs=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oycxdeYz0Etm4LbmHeaMSdIoVVjeEZVEAMvuOHxaW1VkRVY9dLWxcZEsviEAKZB// Fnmv4HQjL//7zHHPlUWMdSGEzki6AZvEti6Ih3o3ZeHeKPjpMf4bMrH/zmjf2FXQni Wu4Nx5dSqjz9F12H3HmxfQgs3vEIMyf2W8LXMHiU= Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id 39300384D14D for ; Thu, 20 Oct 2022 18:12:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 39300384D14D Received: by mail-oi1-x236.google.com with SMTP id x188so532837oig.5 for ; Thu, 20 Oct 2022 11:12:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7hIq2qxDJMng+ZQtN/hmgTEU8TKHZocaZInHiZ0EvGs=; b=O5HHdVnxaDpBM2oTGBGzTdRWblTqo9V0J6PU5M81ibJruUDWBWyLv68aZGNa9X0+ui iEZW9E8kVBEUym93GJdp/OcVTtzB50oOMRnsp8bQl5gtUPR6b6TGVvHFwOGJ03eIOBZZ ud+4dovY/0+Xqf59lzo4GEu+v+5yheGylBq/+3phqrewN1VwCOkEwDPlI4RW9CmQuCkc jteUnSZpzjKYSLwSovST+VyxcJvmmV+yfXmhH9/DKcS2uGPh2T+62kinafaLGKclYH5w 5iHyqAQ2WRWVFeIpTOjmePU0uQ0MP9i+KSAG2iTZpvI9lf7TawmHAMPJwu4Ug5OOzY3x SQKw== X-Gm-Message-State: ACrzQf0kgdim1Nl8PcuUcmS+0JALOsaAMdaZhXrRElmHOVTQHOd+VEvK xnfw7oA8JKjeTCyAgJvMMcAzPQ== X-Google-Smtp-Source: AMsMyM4wFkjWOevXDR2WG1vedPerkd5WMIi8KeaXFSZ723rhPqSgU177x+IPv1zqOQIlPe6HFO0Qkg== X-Received: by 2002:aca:bc06:0:b0:354:cf3a:b81a with SMTP id m6-20020acabc06000000b00354cf3ab81amr22489273oif.53.1666289558467; Thu, 20 Oct 2022 11:12:38 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:7d19:dd57:1ff9:1f14:a9d5? ([2804:1b3:a7c3:7d19:dd57:1ff9:1f14:a9d5]) by smtp.gmail.com with ESMTPSA id l8-20020aca3e08000000b0035028730c90sm230583oia.1.2022.10.20.11.12.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 11:12:37 -0700 (PDT) Message-ID: Date: Thu, 20 Oct 2022 15:12:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 22/30] Linux: Assume and consolidate getsockname wire-up syscall Content-Language: en-US To: Joseph Myers References: <20221019221433.1082017-1-adhemerval.zanella@linaro.org> <20221019221433.1082017-23-adhemerval.zanella@linaro.org> Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella Netto via Libc-alpha Reply-To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 19/10/22 21:01, Joseph Myers wrote: > On Wed, 19 Oct 2022, Adhemerval Zanella via Libc-alpha wrote: > >> And disable if kernel does not support it. > > How did you determine what #undefs to add? I'd have expected a #undef for > 32-bit SPARC at least (where getpeername and getsockname were only added > to the compat syscall table for SPARC in 4.20 (Linux commit > 1f2b5b8e2df4591fbca430aff9c5a072dcc0f408)). > I wrongly assumed the comments on sparc kernel-features.h for socket support was up to date, which does not seems the case. I check the kernel history and fix it.