From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-5.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2C68B1F8C6 for ; Tue, 14 Sep 2021 02:38:11 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 21F883858415 for ; Tue, 14 Sep 2021 02:38:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 21F883858415 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631587089; bh=3tZMKlydnI1N/NV1F1K0ti0eGrbDJ3AQxeVXwvifp64=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CP2MymOzHwlfHnAAS6Pia6+09pUDTvDSIM5QYz9mhzf2rENDLw8CtkiXYhhQmIpE4 gj8C7MeydaahvvyVLeu4uiIl4ZdQ1VMY6yIbJKSiho5wMxYxmLSFWULjKNPS1jaT6Y h8h/nwVHRjgcH8ysquxRNDfbDLf1+X1UelieYVdo= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A3690385802E for ; Tue, 14 Sep 2021 02:35:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3690385802E Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-jiYm8AtmMKuuD2r8035MaQ-1; Mon, 13 Sep 2021 22:35:55 -0400 X-MC-Unique: jiYm8AtmMKuuD2r8035MaQ-1 Received: by mail-qv1-f70.google.com with SMTP id ci14-20020a056214054e00b0037a75ff56f9so13239049qvb.23 for ; Mon, 13 Sep 2021 19:35:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3tZMKlydnI1N/NV1F1K0ti0eGrbDJ3AQxeVXwvifp64=; b=kUZMIbIJvxvlWqla5fFSOL3JmgwUfN/qxM31vibQ6FGEdzWOSrVLH18TF5XmDeV3Rt P+qKDns25CFIoCHZdiLF7+hvrTmz0/yVWTPLAStiSmCnkfRniK6+FOH+3e/0xm/hyKHQ U91BSbe0RFOcngtbUDYLZRoXntA1CYJJXPZgjN1S/pBasB98m5HmSlwTZZ2cDcWaLwdv Ckl+x9wRVqJeCgQxMDtPPopcvd138coLjFR7e3H9547wtXne7VdtkKdq5ltrK80mTSuk zFjA2RiyTGyPDjvSaxFdCCjFT99ON6Zklbj3ni+N/n+LnpLNfuDLHY8TXqPDrhrgTkU5 +mVg== X-Gm-Message-State: AOAM531sxF0fLMut/8s8v/y5TerI3z72FDvxKrFzZ61mQQaAV5SJnX5t l9CcOfsHOp2+6IKky3dj4tpo6PfHEJnOPLr/z44QC+WMoEOWeociHeBQiPxXhlguwlvEtjTWW9z BUGxizw82E/PGCOxgDCRx0GKgF5nxLrVDYjchHrc2SqY9BcYF7GxW87146CX7Rnpbgm+Vtg== X-Received: by 2002:a05:620a:1aa6:: with SMTP id bl38mr2753220qkb.36.1631586954324; Mon, 13 Sep 2021 19:35:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCk/pB+VQe41Y1ob9K1RfG7lBM9qWMWxCSwApfH+yKz2DqZAWGG7kTDcSC+Xn5bVcRZjazyQ== X-Received: by 2002:a05:620a:1aa6:: with SMTP id bl38mr2753201qkb.36.1631586954051; Mon, 13 Sep 2021 19:35:54 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id g12sm6381930qkm.112.2021.09.13.19.35.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 19:35:53 -0700 (PDT) Subject: Re: [PATCH 5/5] x86_64: Add evex optimized bcmp implementation in bcmp-evex.S To: Noah Goldstein , DJ Delorie References: <20210913230506.546749-1-goldstein.w.n@gmail.com> <20210913230506.546749-5-goldstein.w.n@gmail.com> <2ca0771e-2d1d-c0dd-ac98-8f6946d7b469@redhat.com> Organization: Red Hat Message-ID: Date: Mon, 13 Sep 2021 22:35:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Cc: GNU C Library Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 9/13/21 10:05 PM, Noah Goldstein wrote: > On Mon, Sep 13, 2021 at 8:18 PM Carlos O'Donell wrote: > >> On 9/13/21 7:05 PM, Noah Goldstein via Libc-alpha wrote: >>> No bug. This commit adds new optimized bcmp implementation for evex. >>> >>> The primary optimizations are 1) skipping the logic to find the >>> difference of the first mismatched byte and 2) not updating src/dst >>> addresses as the non-equals logic does not need to be reused by >>> different areas. >>> >>> The entry alignment has been fixed at 64. In throughput sensitive >>> functions which bcmp can potentially be frontend loop performance is >>> important to opimized for. This is impossible/difficult to do/maintain >>> with only 16 byte fixed alignment. >>> >>> test-memcmp, test-bcmp, and test-wmemcmp are all passing. >> >> This series fails in the containerized 32-bit x86 CI/CD regression tester. >> >> https://patchwork.sourceware.org/project/glibc/patch/20210913230506.546749-5-goldstein.w.n@gmail.com/ > > > Shoot. No worries! That's what the CI/CD system is there for :-) > AFAICT the first error is: > *** No rule to make target '/build/string/stamp.os', needed by > '/build/libc_pic.a'. I think a normal 32-bit x86 builds should show this issue. You need a gcc that accepts -m32. I minimally set: export CC="gcc -m32 -Wl,--build-id=none" export CXX="g++ -m32 -Wl,--build-id=none" export CFLAGS="-g -O2 -march=i686 -Wl,--build-id=none" export CXXFLAGS="-g -O2 -march=i686 -Wl,--build-id=none" export CPPFLAGS="-g -O2 -march=i686 -Wl,--build-id=none" Then build with --host. e.g. /home/carlos/src/glibc-work/configure --host i686-pc-linux-gnu CC=gcc -m32 -Wl,--build-id=none CFLAGS=-g -O2 -march=i686 -Wl,--build-id=none CPPFLAGS=-g -O2 -march=i686 -Wl,--build-id=none CXX=g++ -m32 -Wl,--build-id=none CXXFLAGS=-g -O2 -march=i686 -Wl,--build-id=none --prefix=/usr --with-headers=/home/carlos/build/glibc-headers-work-i686/include --with-selinux --disable-nss-crypt --enable-bind-now --enable-static-pie --enable-systemtap --enable-hardcoded-path-in-tests --enable-tunables=yes --enable-add-ons > Also, does anyone know what make/configure commands I need to reproduce > this on a x86_64-Linux machine? The build log doesn't appear to have the command. DJ, Should the trybot log the configure step? -- Cheers, Carlos.