From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2F8441F85E for ; Thu, 12 Jul 2018 19:35:21 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=Rej93L8yYjps/5dG jpCyTAfv5C0J5SM1HaKqOK7O7uu06wc0kuKsQgRYw7T4cnU+YtxxgGJoTuGSeTAn 9FmWOHIkQH5ayKoIUxIEXqcUMEQazWNN7Xgclk5dCgLCsHmXMIcIotwGdh0OAfVh NdwdGOHVaO5EmqzUbayCF1NsX3Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=YmvCYxOTWxV7sSCEst0r2I W4KO0=; b=c20iGE+2PCqYKJvKVAPnCcJeDKroWEzJcQhWPiyfEMVTsoHtHu9S9t HnGcv0iK/+l4rmSoVWam1oHsR4mxbZiYlx/IDaIZINkPtB1dv2FefyL78GnZWka0 azIVkNGGT6XghpZamwFg0/6txYo6D5ELG8EOFIVgmuIc7mgiPD/YY= Received: (qmail 123330 invoked by alias); 12 Jul 2018 19:35:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 123320 invoked by uid 89); 12 Jul 2018 19:35:17 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions To: Adhemerval Zanella , libc-alpha@sourceware.org References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> <0cdb26a0-444c-3b42-f540-2bcf5ed393be@linaro.org> From: Florian Weimer Message-ID: Date: Thu, 12 Jul 2018 21:35:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <0cdb26a0-444c-3b42-f540-2bcf5ed393be@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 07/12/2018 09:32 PM, Adhemerval Zanella wrote: > > > On 12/07/2018 14:52, Adhemerval Zanella wrote: >> >> >> On 12/07/2018 13:46, Florian Weimer wrote: >>> On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: >>>> +int >>>> +thrd_join (thrd_t thr, int *res) >>>> +{ >>>> +  void *pthread_res; >>>> +  int err_code = __pthread_join (thr, &pthread_res); >>>> +  if (res) >>>> +   *res = (int)((uintptr_t) pthread_res); >>>> + >>>> +  return thrd_err_map (err_code); >>>> +} >>> >>> Slight inconsistency with intptr_t above. >> >> Indeed, it seems there is no need to cast. > > In fact the cast this construction is still required, since the pthread_join > returned value might have a different size of the expected c11 thrd_join. I meant the inconsistency between intptr_t and uintptr_t. Florian