From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A27561F601 for ; Mon, 5 Dec 2022 16:42:06 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="sW/dq9ge"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D362E3945C1B for ; Mon, 5 Dec 2022 16:42:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D362E3945C1B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670258525; bh=kbZq6mjhx3UEKKnHDLyqmFpWTeSijW1dCdMp1M0CA54=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=sW/dq9gevuzzIYQKJd6T0inYjej2PBaAUDb+WYRkMg6oWEUOJu0LXg+hi6DzCEOHo fcdPEpDRbpj69DK2DanTKKwGnFoThaepuqbKlTosLBN22Vgo02r1yuUD03UsV46GHF FxIlG5iwz6He+vUw1ZnPL4eYnffwN3upvn9s6Yl4= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B1DEF39490AD for ; Mon, 5 Dec 2022 16:40:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1DEF39490AD Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-308-sjt02CAtP1-_Nzytad2I8g-1; Mon, 05 Dec 2022 11:40:24 -0500 X-MC-Unique: sjt02CAtP1-_Nzytad2I8g-1 Received: by mail-il1-f199.google.com with SMTP id i11-20020a056e02152b00b00303642498daso2196364ilu.5 for ; Mon, 05 Dec 2022 08:40:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kbZq6mjhx3UEKKnHDLyqmFpWTeSijW1dCdMp1M0CA54=; b=5aym0BrFLSjSzPoMMHeNmh9Wz6p2TE7mT38esPIgrgYxwX+Bc7aXn56mg55HqNiGB/ Avm6jGLx1/VAcIytsO7m9z/pou00M2N5U3zI8FXHWDIQvqfLDDA5nOV/d8Qm7/OHShta ucROlc82lP68o9BIAZ801trHO163SXcKth9E+DJG04yHmV+dX5n1Hlf588rTkIL0JVj/ 34Dg4OhW57hwgThgi3PYAPTh0zNYSbkh7E9TE1F0L5asII25Cke0R/9auwbb7lPFEzZG rw2zXaVXPAlVgkzdo4uESmKYGFRtlSesCN0Z5V76Aw58CYhzX+dgMvDri4R6noy+tUZw a+tw== X-Gm-Message-State: ANoB5pk/E1OdgKWnrLqdWUm0wUSo7Bb/CYm+rPbZLsKVUh1Z0TTdYkIO q7bPn8NzoaWaPYFd5UAgXHguNT+fs7zaDPlnASqzW89L5D9N9S6SXt5ejPqls7hE3sh7uaM1wBL d44/JA5peF/wszZtsElTa X-Received: by 2002:a05:6e02:dc5:b0:302:e604:f814 with SMTP id l5-20020a056e020dc500b00302e604f814mr25518306ilj.113.1670258423539; Mon, 05 Dec 2022 08:40:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf6ywMFfKGCCKS+AynsKUs92AWLKt9NsKKlmnoP/VGONOZXRHt+NYC6bsSgRw1+52XcxuP5/qg== X-Received: by 2002:a05:6e02:dc5:b0:302:e604:f814 with SMTP id l5-20020a056e020dc500b00302e604f814mr25518303ilj.113.1670258423325; Mon, 05 Dec 2022 08:40:23 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id a4-20020a056638058400b0038a13e116a1sm4624931jar.61.2022.12.05.08.40.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 08:40:22 -0800 (PST) Message-ID: Date: Mon, 5 Dec 2022 11:40:21 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 17/30] Linux: consolidate ____longjmp_chk To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20221019221433.1082017-1-adhemerval.zanella@linaro.org> <20221019221433.1082017-18-adhemerval.zanella@linaro.org> Organization: Red Hat In-Reply-To: <20221019221433.1082017-18-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 10/19/22 18:14, Adhemerval Zanella via Libc-alpha wrote: > Checked on x86_64-linux-gnu. LGTM. No regressions on x86_64 and i686. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > --- > sysdeps/unix/sysv/linux/{generic => }/____longjmp_chk.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > rename sysdeps/unix/sysv/linux/{generic => }/____longjmp_chk.c (90%) > > diff --git a/sysdeps/unix/sysv/linux/generic/____longjmp_chk.c b/sysdeps/unix/sysv/linux/____longjmp_chk.c > similarity index 90% > rename from sysdeps/unix/sysv/linux/generic/____longjmp_chk.c > rename to sysdeps/unix/sysv/linux/____longjmp_chk.c > index aac1158853..687cb27133 100644 > --- a/sysdeps/unix/sysv/linux/generic/____longjmp_chk.c > +++ b/sysdeps/unix/sysv/linux/____longjmp_chk.c > @@ -1,4 +1,5 @@ > -/* Copyright (C) 2011-2022 Free Software Foundation, Inc. > +/* longjmp fortify implementation. Linux version. > + Copyright (C) 2011-2022 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > The GNU C Library is free software; you can redistribute it and/or > @@ -28,8 +29,7 @@ > #define called_from(this, saved) ((this) > (saved)) > #endif > > -extern void ____longjmp_chk (__jmp_buf __env, int __val) > - __attribute__ ((__noreturn__)); > +_Noreturn extern void ____longjmp_chk (__jmp_buf __env, int __val); OK. > > void ____longjmp_chk (__jmp_buf env, int val) > { -- Cheers, Carlos.