unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Alejandro Colomar \(man-pages\) via Libc-alpha" <libc-alpha@sourceware.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: linux-man@vger.kernel.org, Glibc <libc-alpha@sourceware.org>,
	Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [PATCH] ioctl_tty.2: Document ioctls: TCGETS2, TCSETS2, TCSETSW2,  TCSETSF2
Date: Fri, 30 Jul 2021 09:59:45 +0200	[thread overview]
Message-ID: <e0b11f78-93c0-e3e4-097f-5e92f0b99e97@gmail.com> (raw)
In-Reply-To: <20210730002104.ug6gfh3xh4anh3e5@pali>

Hi Pali,

On 7/30/21 2:21 AM, Pali Rohár wrote:
> On Friday 30 July 2021 01:39:11 Alejandro Colomar (man-pages) wrote:
>> user@sqli:/usr/include$ grep -rn 'struct termios {'
>> asm-generic/termbits.h:12:struct termios {
> 
> You have there a mistake. It is 'struct termios2', not 'struct termios'.
> 
> And for 'struct termios' it is more complicated as there are two
> different 'struct termios'. One in file <bits/termios.h> (included from
> <termios.h>) and one in file <asm-generic/termbits.h> (included from
> <linux/termios.h>).
> 
> Function tcsetattr() uses 'struct termios' from <bits/termios.h> and
> ioctl TCSETS uses 'struct termios' from <asm-generic/termbits.h>.

Right.

Anyway, it is in the same header:

user@sqli:/usr/include$ grep -rn 'struct termios2' | grep -v define
asm-generic/termbits.h:21:struct termios2 {


Regards,

Alex

> 
>> user@sqli:/usr/include$ grep -rn '<asm-generic/termbits.h>'
>> x86_64-linux-gnu/asm/termbits.h:1:#include <asm-generic/termbits.h>
>> user@sqli:/usr/include$ grep -rn '<asm/termbits.h>'
>> asm-generic/termios.h:12:#include <asm/termbits.h>
>> user@sqli:/usr/include$ grep -rn '<asm-generic/termios.h>'
>> x86_64-linux-gnu/asm/termios.h:1:#include <asm-generic/termios.h>
>> user@sqli:/usr/include$ grep -rn '<asm/termios.h>'
>> linux/termios.h:6:#include <asm/termios.h>
>> user@sqli:/usr/include$ grep -rn '<linux/termios.h>'
>> user@sqli:/usr/include$


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

  parent reply	other threads:[~2021-07-30  8:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210725225506.7404-1-pali@kernel.org>
     [not found] ` <271f5402-95f5-4e65-84ee-a227879e1c33@gmail.com>
     [not found]   ` <20210729173118.pud4xucnt4kncvol@pali>
     [not found]     ` <7d48a1dd-9641-53e9-bb65-868c86f22821@gmail.com>
     [not found]       ` <20210730000915.d6ieqiuqah4tjjxf@pali>
2021-07-30  7:04         ` [PATCH] ioctl_tty.2: Document ioctls: TCGETS2, TCSETS2, TCSETSW2, TCSETSF2 Alejandro Colomar (man-pages) via Libc-alpha
2021-07-30 10:56           ` Pali Rohár via Libc-alpha
     [not found]       ` <20210730002104.ug6gfh3xh4anh3e5@pali>
2021-07-30  7:59         ` Alejandro Colomar (man-pages) via Libc-alpha [this message]
2021-07-30 10:48 ` [PATCH v2] " Pali Rohár via Libc-alpha
2021-07-30 18:20   ` Alejandro Colomar (man-pages) via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0b11f78-93c0-e3e4-097f-5e92f0b99e97@gmail.com \
    --to=libc-alpha@sourceware.org \
    --cc=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).