From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B19B01F4B4 for ; Tue, 13 Oct 2020 14:27:51 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 98C8D38708B9; Tue, 13 Oct 2020 14:27:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 98C8D38708B9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602599270; bh=RkU5xfUZEO9ZKQob96Rt/VMO+NQwNNSCWMsrXJnvp5I=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BJetxACkQrk23CPJ7/srtSUCAFupxBh5SWtUu5LDs6YDrgUcA4eycPNbRGjxYN94v BDFnsKkGzkDKumigEdy4q1zTjNQw2camFWOf42Nr6om1QapaiEKImsRiB8uf7mqZWL uj/agAur7oLC7Xi22ACa30IvehZidVbf+QCSBKRg= Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by sourceware.org (Postfix) with ESMTPS id C63413851C0E for ; Tue, 13 Oct 2020 14:27:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C63413851C0E Received: by mail-qt1-x841.google.com with SMTP id m9so29101qth.7 for ; Tue, 13 Oct 2020 07:27:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=RkU5xfUZEO9ZKQob96Rt/VMO+NQwNNSCWMsrXJnvp5I=; b=temwr/Xsz1kmVgGs8qk1LlrUrVnnxYcTyBAkU8nPLL1DJgSUzRV13QvCoYwS7GE79a QmJD4WT/EdxGgv5YGcyq+B/FSFsMY6EGJweZmkgwsX9Xc8l3t2kMyn/VYEjB0HhLzk3O G/roCnB/ErL1kPvGeU8l9x2s7U115VGalfCY5O9y7oNksX5PU0XDCcxlAYSXgtfXwXnV 0xXI3x7UjSX1qFE8bhdEywJMf+ud01z5qzdgt0OAG3sbZuKwbT01LTJOJ4piF7owJo0g z+dS14FRK58hbQp8w8DcdpS04vxXHmiJAr1Ek0BxfP6CRmkiuz0qK3C+GiCoD0skyX7d kP/w== X-Gm-Message-State: AOAM531DFwleP31P8tmLq+dGogiIAJFdxxqGWICE/PVtmyvXBbKebw5V yhIs6BQtAwCzSMSjuNQ76MLN8ELvEZW3yQ== X-Google-Smtp-Source: ABdhPJwjETp4vZTWFzvW2rWGrDhjID7AADkfXAV1PG8NJ9ovVPQPPQu2PhPwsDu2SoeaAPMw/o0eeg== X-Received: by 2002:aed:29e3:: with SMTP id o90mr14469099qtd.90.1602599266907; Tue, 13 Oct 2020 07:27:46 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id k4sm2484qkj.46.2020.10.13.07.27.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2020 07:27:46 -0700 (PDT) Subject: Re: [PATCH 15/16] linux: Add {f}stat{at} y2038 support To: "H.J. Lu" References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-16-adhemerval.zanella@linaro.org> <20201006114802.1450d29b@jawa> <99a35800-d0ed-5561-b36b-4416f041ab5d@linaro.org> <331ab260-ef82-8e94-7148-5522fdb6e195@linaro.org> <20201013155838.0e61252b@jawa> <250a2b16-f06a-7215-bb8a-445511a4976f@linaro.org> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: Date: Tue, 13 Oct 2020 11:27:43 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Cc: GNU C Library , Alistair Francis Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 13/10/2020 11:23, H.J. Lu wrote: > On Tue, Oct 13, 2020 at 7:18 AM Adhemerval Zanella via Libc-alpha > wrote: >> >> >> >> On 13/10/2020 10:58, Lukasz Majewski wrote: >>> Hi Adhemerval, >>> >>>> On 07/10/2020 09:52, Adhemerval Zanella wrote: >>>>> >>>>> >>>>> On 06/10/2020 06:48, Lukasz Majewski wrote: >>>>>> Hi Adhemerval, >>>>>> >>>>>>> A new struct __stat{64}_t64 type is added with the required >>>>>>> __timespec64 time definition. Both non-LFS and LFS support were >>>>>>> done with an extra __NR_statx call plus a conversion to the new >>>>>>> __stat{64}_t64 type. The statx call is done only for >>>>>>> architectures with support for 32-bit time_t ABI. >>>>>>> >>>>>>> Internally some extra routines to copy from/to struct stat{64} >>>>>>> to struct __stat{64} used on multiple implementations (stat, >>>>>>> fstat, lstat, and fstatat) are added on a extra file >>>>>>> (stat_t64_cp.c). Aslo some extra routines to copy from statx to >>>>>>> __stat{64} is added on statx_cp.c. >>>>>>> >>>>>>> Checked with a build for all affected ABIs. I also checked on >>>>>>> x86_64, i686, powerpc, powerpc64le, sparcv9, sparc64, s390, and >>>>>>> s390x. >>>>>> >>>>>> When do you plan to pull this patch set to -master? >>>>>> Those patches have been available for review on the mailing list >>>>>> for more than two months now. >>>>> >>>>> Hi Lukasz, thanks to remind me. I will rebase against master and run >>>>> some regressions tests against some platforms and push it. >>>>> >>>> >>>> One required change with the rebase is adapt the riscv32 ABI to >>>> exclude the __{f,l}xstat{at} symbol and replace with proper {f,l}stat >>>> ones. It is possible because the new ABI was added on current >>>> development branch, however one minor inconvenient is the toolchain >>>> need to be rebuild with a updated glibc branch to avoid linking >>>> failures with libstd++ (which uses __{f,l}xstat{at}). >>>> >>> >>> I'm not sure if this is related, but on my ARMv7 (32 bit) sandbox there >>> is an issue with fstat accesses to files. >>> >>> When I try to run a program build against newest glibc (installed in >>> /opt/lib) I do see issues with {f}stat on other libraries (e.g. >>> /opt/lib/librt.so). To be more specific I do experience the EOVERFLOW >>> error: >>> >>> error while loading shared libraries: librt.so.1: cannot stat shared >>> object: Error 75 >>> >>> The "base" glibc is 2.28 (installed in /lib). The glibc under test is >>> the newest master installed in /opt/lib. >>> >>> I'm now investigating this issue. >> >> I am not sure what it might be based on these information, could you >> provide a strace so we can pinpoint what might the issue? >> >> The arm-linux-gnueabihf testing I did was on a aarch64 kernel (4.12.13). >> Besides the make check without regression, I could run system binaries >> with ./testrun.sh. >> >> I will check on a different kernel/system with a 32-bit kernel. > > FWIW, I got > > FAIL: glibcs-armeb-linux-gnueabi-be8 check > FAIL: glibcs-armeb-linux-gnueabi check > FAIL: glibcs-armeb-linux-gnueabihf-be8 check > FAIL: glibcs-armeb-linux-gnueabihf check > FAIL: glibcs-m68k-linux-gnu-coldfire check > FAIL: glibcs-m68k-linux-gnu-coldfire-soft check > FAIL: glibcs-microblazeel-linux-gnu check > FAIL: glibcs-mipsel-linux-gnu-nan2008-soft check > FAIL: glibcs-mipsel-linux-gnu-soft check > FAIL: glibcs-mips-linux-gnu-nan2008-soft check > FAIL: glibcs-mips-linux-gnu-soft check > FAIL: glibcs-powerpc-linux-gnu-soft check > FAIL: glibcs-riscv32-linux-gnu-rv32imac-ilp32 build > FAIL: glibcs-riscv32-linux-gnu-rv32imafdc-ilp32 build > FAIL: glibcs-riscv32-linux-gnu-rv32imafdc-ilp32d build > FAIL: glibcs-sh3eb-linux-gnu check > FAIL: glibcs-sh4eb-linux-gnu check > FAIL: glibcs-sh4eb-linux-gnu-soft check Joseph has raised this earlier, I just pushed a fix to update the libc.abilist (880a12e96df8b330350f565d93677bccf4237e1d). > UNRESOLVED: glibcs-riscv32-linux-gnu-rv32imac-ilp32 check > UNRESOLVED: glibcs-riscv32-linux-gnu-rv32imac-ilp32 install > UNRESOLVED: glibcs-riscv32-linux-gnu-rv32imac-ilp32 mkdir-lib > UNRESOLVED: glibcs-riscv32-linux-gnu-rv32imafdc-ilp32 check > UNRESOLVED: glibcs-riscv32-linux-gnu-rv32imafdc-ilp32d check > UNRESOLVED: glibcs-riscv32-linux-gnu-rv32imafdc-ilp32d install > UNRESOLVED: glibcs-riscv32-linux-gnu-rv32imafdc-ilp32d mkdir-lib > UNRESOLVED: glibcs-riscv32-linux-gnu-rv32imafdc-ilp32 install > UNRESOLVED: glibcs-riscv32-linux-gnu-rv32imafdc-ilp32 mkdir-lib Since this moved the __{f,l}xstat{at}{64} symbols to compatibility ones and made it the {f,l}stat{at}{64} the ones exported by libc, it requires to rebuild the riscv32 toolchain (since libstdc++.so is linked against the __xstat symbols).