unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Vineet Gupta <vineetg76@gmail.com>
To: libc-alpha@sourceware.org
Cc: alistair23@gmail.com, linux-snps-arc@lists.infradead.org,
	alistair.francis@wdc.com
Subject: Re: [PATCH v3] asm-generic ABI: Allow statx syscall despite fstatat64, fstat64
Date: Mon, 24 Feb 2020 19:13:52 -0800	[thread overview]
Message-ID: <df3e9d71-7d5b-a03b-7b6f-4aa034684307@gmail.com> (raw)
In-Reply-To: <20200225002941.20951-1-vgupta@synopsys.com>

On 2/24/20 4:29 PM, Vineet Gupta wrote:
> An old version of asm-generic syscall ABI (e.g. ARC 2013) provided
> fstat[at]64 syscalls for implementing the stat family.
> 
> These sycalls are passthru (no interworking/itemized-copy needed
> between kernel and user structs since they are binary comaptible).
> However with switch to 64-bit time_t the compatibily goes away so we
> need explicit interworking. Luckily such code already exists albeit it
> uses the statx syscall.
> 
> So this patch reworks the asm-generic based stat functions to use the
> statx code-path if the arch so desires. It essentially reworks the commit
> 6bbfc5c09fc5b5e3 ("Add statx conditionals for wordsize-32 *xstat.c")
> 
> This will be used by ARC port for 64-bit time_t. But it has no real
> bearing on 64-bit and can just be independently opted-in by an arch port
> provided the ABI supports it.

Oh wait. Can we avoid this churn by simply undef __NR_fstat64 and __NR_fstatat64
from ARC sysdep.h ? And it will then automatically fallback to statx code !

  reply	other threads:[~2020-02-25  3:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 18:23 [PATCH] asm-generic ABI: Allow statx syscall despite fstatat64,fstat64 Vineet Gupta
2020-02-24 18:39 ` Florian Weimer
2020-02-24 19:03   ` Vineet Gupta
2020-02-24 19:13     ` Florian Weimer
2020-02-24 19:27       ` Vineet Gupta
2020-02-24 19:38         ` Florian Weimer
2020-02-24 22:15           ` [PATCH v2] " Vineet Gupta
2020-02-25  0:09             ` Joseph Myers
2020-02-25  0:29               ` [PATCH v3] " Vineet Gupta
2020-02-25  3:13                 ` Vineet Gupta [this message]
2020-02-25 16:10                   ` [PATCH v3] asm-generic ABI: Allow statx syscall despite fstatat64, fstat64 Joseph Myers
2020-02-25 16:55                     ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df3e9d71-7d5b-a03b-7b6f-4aa034684307@gmail.com \
    --to=vineetg76@gmail.com \
    --cc=alistair.francis@wdc.com \
    --cc=alistair23@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).