From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 449FF1F461 for ; Mon, 20 May 2019 13:29:35 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=vJBgmN88qZnC+hl/ EQ7ADRLTtQjXqohF/UbXD7HlI8jOdJRuNbfixdCiX3Ph9jqpt9e/qe4/h2gMXvnj d3QjuRggInDPM+vdS7s7I6VHeyNWwz64GaF2HyTv2bBv7VEn4GJCOgv0BTNI9mYZ goSNu1pSv5IOFP4WR+27Y42PJjc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=VDbjkBtALxnIep3TUcE8/0 Ip6bI=; b=JQ+Ix1wvYLmz4aY6A2capOPMxOIoQa6O2ptyO5K83wsnPsOSQGuC4u uxyXhYItD/MB1uFDi/jIIgj9V9TrM3OBVra27ZmZOU65eVNubBRCB8GMKXsOWMV/ skQGgaSREqlqzVqWQ7cP9zNTjwAKgmYAOgsQrV8y9K/V2A/zgjBqQ= Received: (qmail 52240 invoked by alias); 20 May 2019 13:29:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 52231 invoked by uid 89); 20 May 2019 13:29:32 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-vs1-f67.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8h6mwi8DsnVznienwFCNesluoQsNuVm1obichOlrwx8=; b=KHgWxJt65rcEBPFR2uEQ/lINutObogu6kDSWDAwrLy3JZXeaRjyp8vDjRDK95qJGO4 ccswBTCxetnbeYlu2PLEH9tUiARWmfzo5g0b4TJmhUCkITvyBzfRUCe3nBNAF/m0Mvie JG9j3WsGLuhOvsIkL3XaQtKjdCUlcZdfh/JoqLxSwg7CLawa9KLm90csNiIjm0x5sxx8 ODBCRiq8Kv6dJRzl1nNNEGHPe087ZFV1dypveBNXgWB59JnSkZ3Ya31fHKNXf/BFL3Qk YOkIw7wBZtoZkuxxwa+xK82H6xz0lxMaFx/SeYpV1QM58RhpntVIABEza66p2YBLwWXV xv3Q== Subject: Re: [PATCH 3/5] sysvipc: Consolidate semtimedop s390 To: Arnd Bergmann Cc: Florian Weimer , GNU C Library References: <20190516151249.19029-1-adhemerval.zanella@linaro.org> <20190516151249.19029-3-adhemerval.zanella@linaro.org> <87mujms8ye.fsf@oldenburg2.str.redhat.com> <907d21c0-fda8-ae6e-b9e7-f5fbc5deffbe@linaro.org> <875zq9qw8o.fsf@oldenburg2.str.redhat.com> <5AE6FA86-C1D5-4103-8DA0-73F87B22DE2D@linaro.org> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: Date: Mon, 20 May 2019 10:29:26 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 17/05/2019 16:09, Arnd Bergmann wrote: > On Fri, May 17, 2019 at 2:30 PM Adhemerval Zanella > wrote: >>> Il giorno 17 mag 2019, alle ore 06:13, Florian Weimer ha scritto: >>> >>> * Adhemerval Zanella: >>> >>>>> On 16/05/2019 12:41, Florian Weimer wrote: >>>>> * Adhemerval Zanella: >>>>> >>>>>> diff --git a/sysdeps/unix/sysv/linux/ipc_priv.h b/sysdeps/unix/sysv/linux/ipc_priv.h >>>>>> index 65adbb093e..49018c1b28 100644 >>>>>> --- a/sysdeps/unix/sysv/linux/ipc_priv.h >>>>>> +++ b/sysdeps/unix/sysv/linux/ipc_priv.h >>>>>> @@ -34,4 +34,7 @@ struct __old_ipc_perm >>>>>> #define MSGRCV_ARGS(__msgp, __msgtyp) \ >>>>>> ((long int []){ (long int) __msgp, __msgtyp }) >>>>>> >>>>>> +#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \ >>>>>> + (__nsops), 0, (__sops), (__timeout) >>>>> >>>>> Maybe add a reference to the s390 version? >>>> >>>> What about: >>>> >>>> /* This macro is required to handle the s390 variants, which passes the >>>> arguments in a different order than default. */ >>> >>> Isn't this for s390 (31-bit) only? >>> >> >> Indeed, I will change to “s390-32 variant”. > > According to the kernel sources, the odd sys_s390_ipc function is > used in both native 64-bit and compat 32-bit variants. The 64-bit > s390 ABI also started out with a maximum of five arguments, > so the wrapper was kept there, see: > > arch/s390/kernel/syscalls/syscall.tbl:117 common ipc > sys_s390_ipc compat_sys_s390_ipc > Thanks for remind me this is not for 31-bit only. I moved the sysdeps/unix/sysv/linux/s390/s390-32/ipc_priv.h to sysdeps/unix/sysv/linux/s390/ipc_priv.h.