From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 34CFB1F45E for ; Wed, 12 Feb 2020 13:24:49 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=a1mNhavfro0CSAi8 /py5bqmwZDimApQbPucm7a6kqtsCTBHiZvOTWCLC5dWsld8viwg2EQGQlhe10gEe NUB4KIF3NacBJAEpAzHTd8ba2PHb6LgqbOfY5hUiMlkQFpcNU+QeVLvDP+2H1vHB IFDC1Ggy9l4ADfsz0UBQNUYYcjs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=qs2oj2qmx2MBM3H8ac5o1r LLEhE=; b=d2BAlQUzOuRYOFgYmoG5mS6fVyYTJB+ZEtqaP80VrO/DGfvyhkfhOh p0v0isMbS9JZw2bu9KGJoSWmFPqH4zRObLOxOAMO5v/O2VPz7RZ1/cSdmhUaMIjU l5cYJ7un/kdGEwcJi0Yf2jSEEsgGvyBaCyS9vLqDWeEQo7AIBWsf0= Received: (qmail 56180 invoked by alias); 12 Feb 2020 13:24:45 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 56026 invoked by uid 89); 12 Feb 2020 13:24:28 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1j8iK9t0QBkuDGdXD1H5KJL/qheve2X7b/nzDLKhnbQ=; b=lcztEfi8c2YTpLTdM4KFEYr95mChs059Ue6NJFIXLTTUFGv5xVQ791TjIe+5pDQFJv tQw5YL6elEWgqczltmfRpwEk1fX+8n+m+in2XTK2hWT5PY5Mv5Q/qSbKBH+1FQOc2c09 rG3BkRKW8lAdtpeSLemr+iX517bdWGlIuV4muNzGgo52arcuJRX16/+xiBqtnl32xHLj pCbIX8VhC43UTeQfIZNXl4x4rzxNhprqQIIlnRRxnyDMq2WPDvM9rlms6U1zyuJBFl1X T+Buepws359YZRJeZ8Kbkk+u9w5bG7SSJqMIDmGE0RZygS2pyOIJ7QzaI2B6YK0uJhmf cMrQ== Subject: Re: [PATCH 02/15] powerpc: Use Linux kABI for syscall return To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20200210192038.23588-1-adhemerval.zanella@linaro.org> <20200210192038.23588-2-adhemerval.zanella@linaro.org> <87pneknc0t.fsf@mid.deneb.enyo.de> From: Adhemerval Zanella Message-ID: Date: Wed, 12 Feb 2020 10:24:14 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87pneknc0t.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 11/02/2020 16:45, Florian Weimer wrote: > * Adhemerval Zanella: > >> It changes the powerpc INTERNAL_VSYSCALL_CALL and INTERNAL_SYSCALL_NCS >> to return a negative value instead of returning the CR value on 'err' >> macro argument. > > value on? This part is unclear to me. > >> The macro INTERNAL_SYSCALL_DECL is no longer required, and the >> INTERNAL_SYSCALL_ERROR_P follows the other Linux kABIS. > > See my other comment about wording here. Ack, I changed based on sparc comments. > > The patch looks reasonable to me. >