unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: liqingqing <liqingqing3@huawei.com>
To: "Paul Eggert" <eggert@cs.ucla.edu>, "Tim Rühsen" <tim.ruehsen@gmx.de>
Cc: <libc-alpha@sourceware.org>, Florian Weimer <fweimer@redhat.com>,
	"Carlos O'Donell" <carlos@redhat.com>,
	Hushiyuan <hushiyuan@huawei.com>, Liusirui <liusirui@huawei.com>
Subject: Re: question about regex
Date: Mon, 20 Jan 2020 18:41:10 +0800	[thread overview]
Message-ID: <dbd2cdae-5a33-593e-83d8-6a3fd0f85afb@huawei.com> (raw)
In-Reply-To: <377311fb-fdf3-6467-3b48-28404d8c3326@huawei.com>



On 2020/1/3 16:09, liqingqing wrote:
> 
> 
> On 2020/1/3 6:14, Paul Eggert wrote:
>> On 1/2/20 8:16 AM, Tim Rühsen wrote:
>>> Meanwhile grep (or libc) seems to exit gracefully:
>>
>> Yes, there's no core dump if the operating system supports stack overflow detection that grep can use. The problem occurs only on OSes that don't do that, or on apps that don't try to detect stack overflow and simply dump core (or worse).
>>
>> On 1/2/20 2:54 AM, liqingqing wrote:
>>
>>> do we have any plan or good ways to fix up the bug as below
>>
>> The best way would be to fix bug#24269, i.e., fix the glibc regex code so that it doesn't blow the stack. If you could write a patch for this bug (something that doesn't hurt performance for ordinary regexps), that would be welcome.
>>

hello everyone, I have read the regex source code and found that it's not a easy work to fix bug#24269 by modify the regex algorithm.
a possible way is that add a backtrack limit to avoid infinite loop. I have tested this way and it works ok.
so what do you think about the bug#24269?  optimize the algorithm or add a backtrack-limit? or not fix.


  reply	other threads:[~2020-01-20 10:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-14  8:44 [discuss] iconv: what's the purpose of the mtrace in the tst-iconv2.c liqingqing
2020-01-02 10:54 ` question about regex liqingqing
2020-01-02 16:16   ` Tim Rühsen
2020-01-02 22:14     ` Paul Eggert
2020-01-03  8:09       ` liqingqing
2020-01-20 10:41         ` liqingqing [this message]
2020-01-20 19:25           ` Paul Eggert
2020-01-21  1:15             ` liqingqing
2020-01-21  8:57               ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbd2cdae-5a33-593e-83d8-6a3fd0f85afb@huawei.com \
    --to=liqingqing3@huawei.com \
    --cc=carlos@redhat.com \
    --cc=eggert@cs.ucla.edu \
    --cc=fweimer@redhat.com \
    --cc=hushiyuan@huawei.com \
    --cc=libc-alpha@sourceware.org \
    --cc=liusirui@huawei.com \
    --cc=tim.ruehsen@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).