From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F1A071F45F for ; Wed, 8 May 2019 22:07:56 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=xzMKjqB8DR6GWcyX Sl/bT9FLuxetKQOl4LABswhJbN/VJbXLIlXwJ90aoGL1P0SqDWFg+glMUW7zpSvy YnEGoU1DSg59RgeTDMpCzjJrG791JQ91zYdBvyTZzU4kI/h9vaB+7DtP3BDynQkP d2jDy6nHQzha9oyXwFuYppiKdbk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=shl4zQI9tm/v0XQ+6opl16 iIfrU=; b=D6xpStdwLohEfGTmEqPCyhkZnQe261xWQGtlPSL8Sk6F5iB1H3Rntr W888B0IEsNgXjXBxWUs5Vv4Penh0RCI+Cf0B4fGeBmvhgzyrO+NWdSWc18EIB0cf EExWlZ8t+HQ1I+/3byZEgjzfCCaDoa7lEY/VvVRRojN1zhhaBeLh0= Received: (qmail 85230 invoked by alias); 8 May 2019 22:07:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 85210 invoked by uid 89); 8 May 2019 22:07:54 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f175.google.com Subject: Re: [patch-ish, WIP] Enhance comments in nsswitch.h To: DJ Delorie Cc: libc-alpha@sourceware.org References: From: Carlos O'Donell Message-ID: Date: Wed, 8 May 2019 18:07:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 5/8/19 5:39 PM, DJ Delorie wrote: > > "Carlos O'Donell" writes: >>> + /* And the link to the next entry. In a typical nsswitch.conf, this >>> + is the passwd->group->hosts link. */ >> >> What does this mean? That this is the next entry in the file after >> translating it into a lit of entries (excluding comments)? > > It's a link to, essentially, the next non-comment line in nsswitch.conf. > There are a lot of things labelled "next" in this header, keeping track > of next *what* is important. I agree. Please mention that in the comment. > We also don't have a lot of consistency and well-known terms for things > like "passwd or hosts" vs "dns or files" etc. > >>> +/* The rest of this header is not-data. */ >> >> Remove this comment. > > This is just a hint to me to stop reading the file ;-) Ha! :-) Please post a v2. I'd like to see this committed. -- Cheers, Carlos.