From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 09EF61F466 for ; Fri, 31 Jan 2020 21:10:07 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:cc:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=tN1mAWMW03jkuE/P ws5dQ7NK1kyOFXYkk/4e1oQKv2HB25HhF0NT6RHtp24UcXkg9KWCZSJnKlgeGBb0 iVCK+CDIx8p5yIZourzpd6yZo+lGvmrsM2jCMMSfVY/jlYmCpS7lUX8dlbtOvKZh n+YZUfpRhk/xpz99LsnF2Sr4JgQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:to:cc:references:from:subject:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=cjlPP8EHr4OtcOmLrJg7xd 89NUY=; b=thszbP13xQKBGK8ACo7QMLMJA5U+WiwoPR6vp+uwpcXRUIDkPl1wYe 8ffTXuVQWL43nPhNPwCWrU2/opLtm3xTSVF8xPC4vjIFnZRrb6qRB1Omn/zeYgMg UXa+Y6tWiR15mTrtL0zVM3QNPjys6m8OY9XLXRVrcfIFITyGMg474= Received: (qmail 76102 invoked by alias); 31 Jan 2020 21:10:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 76092 invoked by uid 89); 31 Jan 2020 21:10:04 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qk1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9kJlZaO86OvZAktBikGzM4fKAWCDYzo9WFPvOsG2EL0=; b=F9fyoQ7ItX8oBa8//Bnt9fq5Xpo7+WEsCwv0M6ze8ViTA8Z92xLJDUeEQHQXggrAOj FByMFwqV0WWIsPZfv8OfEtCKkkNL675JzM3zowFt3svVZ3H9agWE5XKLvcvX4CpdO69R 8lDq22KZaMyKE+B760rtrln4NZmHzhCNpg9ZtZfHwgW9Qtqg4frUSYRPDfQVXSQIB71w zhiDw6MmeqISN5GP1m2dah+pjS8v3V6lasLWRDnEoAhaKHL7uRC6zwWTkC+1wK+SsIVT UWE/H2A7zhiZkBLF3s0TMZysQAFN+NyrE3cbW7t36NLOmeciuhjlHGjkhVwsUgKjpXhp Tfpg== To: Lukasz Majewski , Joseph Myers , Paul Eggert , Andreas Schwab Cc: Alistair Francis , Alistair Francis , GNU C Library , Siddhesh Poyarekar , Florian Weimer , Florian Weimer , Zack Weinberg , Carlos O'Donell References: <20200108162248.24336-1-lukma@denx.de> From: Adhemerval Zanella Subject: Re: [PATCH] y2038: linux: Provide __sched_rr_get_interval64 implementation Message-ID: Date: Fri, 31 Jan 2020 18:09:55 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200108162248.24336-1-lukma@denx.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 08/01/2020 13:22, Lukasz Majewski wrote: > This patch replaces auto generated wrapper (as described in > sysdeps/unix/sysv/linux/syscalls.list) for sched_rr_get_interval with one which > adds extra support for reading 64 bit time values on machines with > __TIMESIZE != 64. > There is no functional change for architectures already supporting 64 bit > time ABI. > > The sched_rr_get_interval declaration in ./include/sched.h is not followed by > corresponding libc_hidden_proto(), so it has been assumed that newly introduced > syscall wrapper doesn't require libc_hidden_def() (which has been added by > template used with auto generation script). > > Moreover, the code for building sched_rr_gi.c file is already placed in > ./posix/Makefiles, so there was no need to add it elsewhere. > > Performed tests and validation are the same as for timer_gettime() conversion > (sysdeps/unix/sysv/linux/timer_gettime.c). LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > include/time.h | 7 +++ > sysdeps/unix/sysv/linux/sched_rr_gi.c | 73 +++++++++++++++++++++++++++ > sysdeps/unix/sysv/linux/syscalls.list | 1 - > 3 files changed, 80 insertions(+), 1 deletion(-) > create mode 100644 sysdeps/unix/sysv/linux/sched_rr_gi.c > > diff --git a/include/time.h b/include/time.h > index f23bfea737..558923274a 100644 > --- a/include/time.h > +++ b/include/time.h > @@ -203,6 +203,13 @@ libc_hidden_proto (__timer_settime64); > libc_hidden_proto (__timerfd_settime64); > #endif > > +#if __TIMESIZE == 64 > +# define __sched_rr_get_interval64 __sched_rr_get_interval > +#else > +extern int __sched_rr_get_interval64 (pid_t pid, struct __timespec64 *tp); > +libc_hidden_proto (__sched_rr_get_interval64); > +#endif > + > /* Compute the `struct tm' representation of T, > offset OFFSET seconds east of UTC, > and store year, yday, mon, mday, wday, hour, min, sec into *TP. Ok. > diff --git a/sysdeps/unix/sysv/linux/sched_rr_gi.c b/sysdeps/unix/sysv/linux/sched_rr_gi.c > new file mode 100644 > index 0000000000..3d7b484591 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/sched_rr_gi.c > @@ -0,0 +1,73 @@ > +/* sched_rr_get_interval -- get the scheduler's SCHED_RR policy time interval. > + Copyright (C) 2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public License as > + published by the Free Software Foundation; either version 2.1 of the > + License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; see the file COPYING.LIB. If > + not, see . */ > + > +#include > +#include > +#include > +#include > +#include > + > +int > +__sched_rr_get_interval64 (pid_t pid, struct __timespec64 *tp) > +{ > +#ifdef __ASSUME_TIME64_SYSCALLS > +# ifndef __NR_sched_rr_get_interval_time64 > +# define __NR_sched_rr_get_interval_time64 __NR_sched_rr_get_interval > +# endif > + return INLINE_SYSCALL_CALL (sched_rr_get_interval_time64, pid, tp); Ok. > +#else > +# ifdef __NR_sched_rr_get_interval_time64 > + int ret = INLINE_SYSCALL_CALL (sched_rr_get_interval_time64, pid, tp); > + if (ret == 0 || errno != ENOSYS) > + return ret; > +# endif > + struct timespec tp32; > + int retval = INLINE_SYSCALL_CALL (sched_rr_get_interval, pid, &tp32); > + if (retval == 0) > + *tp = valid_timespec_to_timespec64 (tp32); > + > + return retval; > +#endif > +} Ok. > + > +#if __TIMESIZE != 64 > +libc_hidden_def (__sched_rr_get_interval64) > + > +int > +__sched_rr_get_interval (pid_t pid, struct timespec *tp) > +{ > + int ret; > + struct __timespec64 tp64; > + > + ret = __sched_rr_get_interval64 (pid, &tp64); > + > + if (ret == 0) > + { > + if (! in_time_t_range (tp64.tv_sec)) > + { > + __set_errno (EOVERFLOW); > + return -1; > + } > + > + *tp = valid_timespec64_to_timespec (tp64); > + } > + > + return ret; > +} > +#endif > +strong_alias (__sched_rr_get_interval, sched_rr_get_interval) Ok. > diff --git a/sysdeps/unix/sysv/linux/syscalls.list b/sysdeps/unix/sysv/linux/syscalls.list > index 1fa546f231..5d65ed23e0 100644 > --- a/sysdeps/unix/sysv/linux/syscalls.list > +++ b/sysdeps/unix/sysv/linux/syscalls.list > @@ -51,7 +51,6 @@ sched_getp - sched_getparam i:ip __sched_getparam sched_getparam > sched_gets - sched_getscheduler i:i __sched_getscheduler sched_getscheduler > sched_primax - sched_get_priority_max i:i __sched_get_priority_max sched_get_priority_max > sched_primin - sched_get_priority_min i:i __sched_get_priority_min sched_get_priority_min > -sched_rr_gi - sched_rr_get_interval i:ip __sched_rr_get_interval sched_rr_get_interval > sched_setp - sched_setparam i:ip __sched_setparam sched_setparam > sched_sets - sched_setscheduler i:iip __sched_setscheduler sched_setscheduler > sched_yield - sched_yield i: __sched_yield sched_yield > Ok.