From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 446221F55B for ; Tue, 2 Jun 2020 17:27:40 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D3EC388B004; Tue, 2 Jun 2020 17:27:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D3EC388B004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1591118859; bh=Sk0imefetn15uMlSUEgRiHk4Xt3oHvQbNvTS44hkHuA=; h=To:References:Subject:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=OsdQdHLUbMq7hcr867O9PeOJI24uRNyPeNVADMh+wutKQZx4LabmrCLf8JKVjK7v8 pduYtsrwfWQiELmH5Vv0eHs/Js+RiYrya28bpWMcQcQJrzD5HhNyeU+xXlbsb5TXeB HnY+LZhwYkgq2pnotbURkvhqusiX2vy5Hc/8+Mbg= Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id EA2AD386EC79 for ; Tue, 2 Jun 2020 17:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EA2AD386EC79 Received: by mail-qt1-x842.google.com with SMTP id e16so11332097qtg.0 for ; Tue, 02 Jun 2020 10:27:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Sk0imefetn15uMlSUEgRiHk4Xt3oHvQbNvTS44hkHuA=; b=exPZity3qMNRwgmJpEX6X2MfmPBdtoe/xpBldmt1VxDM7nX5q22LLJsTyUG5i9b03n GQ4mzF377jMwxs99hLl80KBTTzQzBGvoWNONVcfawO+PFHBd1/qlBVUvnVTOdzpwA3ku CHoWt0WksgqbwQQmkeCQ5PKx0M0PM7CdSD4snQXH9IwCI11FkyPwBg8/Q3GcVk3K9SVm vp5IKSZUKVrAE+vVwxTe/aQtCjSfGjVzQCjKEOtnovh/YnE6CIMkyA26kSqSpKzXTjC/ oBYNiNDz1re0ANHKL8nQlI2C8VFEgLQMBhkrTpHdGXphztFNdIxboi/Llsiyzruaw/uj N6JQ== X-Gm-Message-State: AOAM532Ias252WszukW9LBzfvFjsQCd6j+dZJtvAfWwjeOkgJAuIT/2i SRTO+IePFf7c4K3CBwMXRFpqqerbApM= X-Google-Smtp-Source: ABdhPJz6CrR5vCMPApUoBp6GtcwZ+EqTMMKtqyShpmWuvLigA1xitwiLkoxWTWM8QjL5FYEU0voWDw== X-Received: by 2002:ac8:6897:: with SMTP id m23mr27826416qtq.379.1591118856334; Tue, 02 Jun 2020 10:27:36 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id s42sm3212002qtk.14.2020.06.02.10.27.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2020 10:27:36 -0700 (PDT) To: libc-alpha@sourceware.org References: <20200602003541.21005-1-vgupta@synopsys.com> <20200602003541.21005-3-vgupta@synopsys.com> <34fc6c13-65e6-dcbb-42b1-1ba9f56b4dfd@linux.ibm.com> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH v2 2/4] iee754: provide gcc builtins based generic fma functions Message-ID: Date: Tue, 2 Jun 2020 14:27:34 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 02/06/2020 14:13, Vineet Gupta via Libc-alpha wrote: > On 6/2/20 5:51 AM, Stefan Liebler via Libc-alpha wrote: >> #endif /* math-use-builtins.h */ >> Please also update the current architecture specific math-use-builtins.h >> file: sysdeps/s390/fpu/math-use-builtins.h >> Otherwise it will break build on s390x. > > Done. > >>> diff --git a/sysdeps/ieee754/dbl-64/s_fma.c b/sysdeps/ieee754/dbl-64/s_fma.c >>> index 876df6e78bdc..9dc5b132b9ee 100644 >>> --- a/sysdeps/ieee754/dbl-64/s_fma.c >>> +++ b/sysdeps/ieee754/dbl-64/s_fma.c >>> @@ -25,6 +25,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> /* This implementation uses rounding to odd to avoid problems with >>> double rounding. See a paper by Boldo and Melquiond: >>> @@ -33,6 +34,10 @@ >>> double >>> __fma (double x, double y, double z) >>> { >>> +#if USE_FMA_BUILTIN >>> + return __builtin_fma (x, y, z); >> >> Architectures which have support for ldbl-128 will use the file >> sysdeps/ieee754/ldbl-128/s_fma.c instead of >> sysdeps/ieee754/dbl-64/s_fma.c. Should this file also be adjusted in >> order to use the builtin if USE_FMA_BUILTIN is set to one? > > Right. > > I used commit f82996f815 "Use GCC builtins for round functions if desired" as > starting point for my change. And seems it was not an ideal reference :-) as round > has far fewer instances than fma. Indeed fma is present in ldbl-128 and dbl-64 so > needs updating in both. I think after this set is upstream I will refactor to make each symbol and its variant (i.g sqrt, sqrtf, etc.) to be define on its own file. The default math-use-builtins will then include each file: /* math-use-builtins.h */ #inclde [...] With default USE_* begin 0. This would allow to add new builtin usage without require to sync with every architecture (and without breaking its build as well). > > But just to be sure s390 is currently not using the newly introduced builtins so > I'll keep them as follows. > > #define USE_SQRT_BUILTIN 0 > #define USE_SQRTF_BUILTIN 0 > > #define USE_FMA_BUILTIN 0 > #define USE_FMAF_BUILTIN 0 > #define USE_FMAL_BUILTIN 0 > #define USE_FMAF128_BUILTIN 0 > > -Vineet It is ok, we can optimize s390 in a subsequent patch (since it does provide fma and sqrtf builtins).