From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-5.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E24741F8C6 for ; Tue, 7 Sep 2021 01:28:39 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 727E6385700A for ; Tue, 7 Sep 2021 01:28:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 727E6385700A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1630978117; bh=j6VhuF7H5wGSXgL6Qy6xHu62GXyV9oG5a2iPc4dRcsg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=G2qa5SNWdukcoIOs9GfbMSQT5H+oFeW88gGphTrpGdj3eMkNHypFSyPhm83nACS8u WVnTaJKPw05TQvD7rHmZrFFnLMKkamVg5nI+XLMGlsjn7TkzH974lKIdN/bK5g4MG5 WIopkJd+BiLU0BMb7MvNO6lakPmVHGVls4HpDW+I= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7A8393858413 for ; Tue, 7 Sep 2021 01:28:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A8393858413 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-n0XvwmtnMzmuk7wlzQ7tAw-1; Mon, 06 Sep 2021 21:28:16 -0400 X-MC-Unique: n0XvwmtnMzmuk7wlzQ7tAw-1 Received: by mail-qt1-f197.google.com with SMTP id l22-20020a05622a175600b0029d63a970f6so11642388qtk.23 for ; Mon, 06 Sep 2021 18:28:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=j6VhuF7H5wGSXgL6Qy6xHu62GXyV9oG5a2iPc4dRcsg=; b=FFxWc+nwdo1ztXbSpdoQL+Q6OrEwdCeckXfNlGS0qlHr0Y1Dl3jQKWgt6amRnrEHw4 Vdyeg0naJXzKNcLc28gLnORBkDPlqKMzKUE0+fUN1/Ak75x1r4mQ+xPyLO1zc5RC/I4Y kSPmRnGpgsJ+Umsw+WXBN5uJkh6DjHQ2GofDNZ8RP2OF6V8OaqgdjGMxw47FV/S3K0aC qEG8q+guqMdykLadeG9cwkj4HmCNhfe4VSQQTMVXe9bVQj+KMOukQvLFpI4TGm2xe+DR bptYA3c2pByZwBTns/bw08P3dTFaelUs+q8WUkJvsDG8SW3rj3E1ax0GEsgFHF0aZTmx JogA== X-Gm-Message-State: AOAM533zoJ1IqqIIxpVIpmUlyaw3QXonbM4+FoidTQrjVBmrDLt7vz1n N5hX3v9ZN8CmWjmaS2HYYWk9W7uZV6ndsa1k13fpchmhk8Hp0cSUL5ujzxybEkto4lxXScFn/eF KtfPkGisoeqN+vqf1zFDb09LJmL8FoFAl7xo12/VBraHLa1665FplfO0o95ZqoE9Fxd1HNg== X-Received: by 2002:a37:a793:: with SMTP id q141mr13529003qke.10.1630978095723; Mon, 06 Sep 2021 18:28:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMtuu5uEslYdYecdKJjXF9JTmEn0/6fG3ht6C9nP2nWUf5306DmD2EZkFsfg1DfVGwyJrstg== X-Received: by 2002:a37:a793:: with SMTP id q141mr13528984qke.10.1630978095455; Mon, 06 Sep 2021 18:28:15 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id h18sm7920664qke.6.2021.09.06.18.28.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Sep 2021 18:28:14 -0700 (PDT) Subject: Re: [PATCH v12 1/2] Add 'codepoint_collation' support for LC_COLLATE. To: Florian Weimer , Matheus Castanho References: <20210906154336.610973-1-carlos@redhat.com> <20210906154336.610973-2-carlos@redhat.com> <878s097h8m.fsf@linux.ibm.com> <87wnntwr3t.fsf@oldenburg.str.redhat.com> Organization: Red Hat Message-ID: Date: Mon, 6 Sep 2021 21:28:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87wnntwr3t.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 9/6/21 1:28 PM, Florian Weimer wrote: > * Matheus Castanho: > >> glibc doesn't build after this patch went in, looks like the assert >> message is missing: >> >> In file included from C-collate.c:22: >> C-collate-seq.c:58:42: error: expected ‘,’ before ‘)’ token >> _Static_assert (sizeof (collseqmb) == 256); > > Sorry, I missed that. I'm testing a patch. Thanks for committing a fix for this. I'm using too new compilers and thinking in too new C :-) I missed it too, C++ allows the assertion with an expression only but current C11 does not. That's an annoying wrinkle fixed in C2x which allows a one-argument version of _Static_assert. This behaviour changed between gcc 8.5 and 9.1 where in 9.1 under -std=c11 started accepting the 1-argument-form _Static_assert. All of our CI/CD is using gcc 11, and I'm using gcc 10, so we would not have seen this. Seems like we need another CI/CD trybot with gcc 6.2! -- Cheers, Carlos.