From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
'GNU C Library' <libc-alpha@sourceware.org>
Subject: Re: [PATCH][AArch64] Cleanup memset
Date: Thu, 27 Feb 2020 11:20:34 +0530 [thread overview]
Message-ID: <d362126d-0e8d-70d3-d6e6-cbbbb53a8627@gotplt.org> (raw)
In-Reply-To: <AM5PR0801MB2035EB8FDD9C75E89E30405283EA0@AM5PR0801MB2035.eurprd08.prod.outlook.com>
On 26/02/20 21:41, Wilco Dijkstra wrote:
> Cleanup memset. Remove unnecessary code for unused ZVA sizes.
> For zero memsets it's faster use DC ZVA for >= 160 bytes rather
> than 256. Add a define which allows skipping the ZVA size test when
> the ZVA size is known to be 64 - reading dczid_el0 may be expensive.
> This simplifies the Falkor memset implementation.
This looks OK in general, although can you please elaborate on the
following:
- What cores did you test on to conclude that 160 is a better threshold
than 256?
- Is the intention to support non-64-byte zva sizes once there is actual
hardware that implements it and not bother with it for now? I agree
with the idea if that's the case, just that it would be nice to have
that documented in the git commit message.
Siddhesh
next prev parent reply other threads:[~2020-02-27 5:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 16:11 [PATCH][AArch64] Cleanup memset Wilco Dijkstra
2020-02-27 5:50 ` Siddhesh Poyarekar [this message]
2020-03-03 14:42 ` Wilco Dijkstra
2020-03-03 15:23 ` Siddhesh Poyarekar
2020-03-03 19:34 ` Andrew Pinski
2020-03-12 15:46 ` Wilco Dijkstra
2020-03-12 17:06 ` Andrew Pinski via Libc-alpha
2020-03-13 2:24 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d362126d-0e8d-70d3-d6e6-cbbbb53a8627@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).