unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH 1/3] <fd_to_filename.h>: Add type safety and port to Hurd
Date: Mon, 17 Feb 2020 15:59:21 -0300	[thread overview]
Message-ID: <cad1883e-d9de-14a2-e28d-2d53c034e2a4@linaro.org> (raw)
In-Reply-To: <08e05663-2437-f2cc-832a-054a2e28a16a@cs.ucla.edu>



On 17/02/2020 15:26, Paul Eggert wrote:
> On 2/17/20 7:18 AM, Florian Weimer wrote:
>> Here's an updated version
> 
> Thanks, it looks good.
> 
>> which adds a dependency on <intprops.h> (a
>> header I really dislike)
> 
> I disliked *writing* intprops.h (what a mess that part of C is!) but I don't dislike *using* it when it's clearer or more reliable than the alternatives.

I think the main problem with intprops.h is it contains a lot 
of clutter not really useful for the current glibc targets,
and it could be simplified with current minimum build compiler
requirement.

Also, although its usage is indeed handy in some situations,
its implementation is somewhat complex and convoluted. I don't
see a better solution with given constraint though.

So the question is if it still worth to keep it in sync with
gnulib, or if is better to push for a more tailored and clean
replacement.

  reply	other threads:[~2020-02-17 18:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 18:10 [PATCH 0/3] <fd_to_filename.h> improvements Florian Weimer
2020-02-14 18:11 ` [PATCH 1/3] <fd_to_filename.h>: Add type safety and port to Hurd Florian Weimer
2020-02-14 18:43   ` Samuel Thibault
2020-02-14 19:08   ` Adhemerval Zanella
2020-02-14 20:21     ` Florian Weimer
2020-02-14 20:28   ` Paul Eggert
2020-02-15 13:16     ` Florian Weimer
2020-02-16  0:02       ` Paul Eggert
2020-02-17 15:18         ` Florian Weimer
2020-02-17 18:26           ` Paul Eggert
2020-02-17 18:59             ` Adhemerval Zanella [this message]
2020-02-17 19:14               ` Paul Eggert
2020-02-14 18:11 ` [PATCH 2/3] Linux: Port ttyname, ttyname_r to <fd_file_name.h> Florian Weimer
2020-02-14 18:11 ` [PATCH 3/3] Linux: Port fexecve to <fd_to_filename.h> Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cad1883e-d9de-14a2-e28d-2d53c034e2a4@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).