From: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Florian Weimer <fweimer@redhat.com>,
"H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: V5 [PATCH] Set tunable value as well as min/max values
Date: Tue, 29 Sep 2020 21:28:22 +0530 [thread overview]
Message-ID: <c877b04b-d80f-9c4d-03c8-3fa972b6a4b0@sourceware.org> (raw)
In-Reply-To: <CAMe9rOqKnrsWvT_y=vOicSitjT7mJSz1XnyY_zXBbwSmJ980qA@mail.gmail.com>
On 29/09/20 20:24, H.J. Lu wrote:
>> Basically, this is what it should look like:
>>
>> if (__minp != NULL
>> && *__minp <= *__maxp
>
> __maxp may be NULL.
>
>> && *__minp >= (__cur)->type.min
>> && *__minp <= (__cur)->type.max)
>> (__cur)->type.min = *__minp;
>>
>> if (__maxp != NULL
>> && *__minp <= *_maxp
>
> __minp may be NULL.
Oops :)
> I don't think we should make such assumptions. Here is the
> updated patch with the check for the subset of (__cur)->type.min
> and (__cur)->type.max.
Fair enough, this version looks good.
Thanks,
Siddhesh
next prev parent reply other threads:[~2020-09-29 15:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 16:07 V2 [PATCH 0/4] ld.so: Add --list-tunables to print tunable values H.J. Lu via Libc-alpha
2020-09-18 16:07 ` [PATCH 1/4] x86: Initialize CPU info via IFUNC relocation [BZ 26203] H.J. Lu via Libc-alpha
2020-09-28 13:08 ` Florian Weimer via Libc-alpha
2020-09-28 13:48 ` H.J. Lu via Libc-alpha
2020-09-28 14:05 ` Florian Weimer via Libc-alpha
2020-09-28 14:20 ` H.J. Lu via Libc-alpha
2020-09-28 14:22 ` Florian Weimer via Libc-alpha
2020-09-28 14:39 ` H.J. Lu via Libc-alpha
2020-09-28 14:47 ` Florian Weimer via Libc-alpha
2020-09-28 17:54 ` V3 [PATCH] " H.J. Lu via Libc-alpha
2020-09-29 7:53 ` Florian Weimer via Libc-alpha
2020-09-29 11:44 ` H.J. Lu via Libc-alpha
2020-10-01 8:46 ` Florian Weimer via Libc-alpha
2020-10-01 19:50 ` V4 " H.J. Lu via Libc-alpha
2020-10-08 13:22 ` PING: " H.J. Lu via Libc-alpha
2020-10-15 12:53 ` PING^2: " H.J. Lu via Libc-alpha
2022-05-02 13:59 ` Sunil Pandey via Libc-alpha
2022-05-03 18:51 ` Sunil Pandey via Libc-alpha
2020-09-18 16:07 ` [PATCH 2/4] Set tunable value as well as min/max values H.J. Lu via Libc-alpha
2020-09-28 13:35 ` Florian Weimer via Libc-alpha
2020-09-28 13:53 ` H.J. Lu via Libc-alpha
2020-09-28 14:03 ` Florian Weimer via Libc-alpha
2020-09-28 17:30 ` Siddhesh Poyarekar via Libc-alpha
2020-09-29 4:00 ` V3 [PATCH] " H.J. Lu via Libc-alpha
2020-09-29 4:45 ` Siddhesh Poyarekar via Libc-alpha
2020-09-29 4:47 ` Siddhesh Poyarekar
2020-09-29 12:30 ` V4 " H.J. Lu via Libc-alpha
2020-09-29 13:50 ` Siddhesh Poyarekar via Libc-alpha
2020-09-29 14:54 ` V5 " H.J. Lu via Libc-alpha
2020-09-29 15:58 ` Siddhesh Poyarekar via Libc-alpha [this message]
2020-09-18 16:07 ` [PATCH 3/4] x86: Move x86 processor cache info to cpu_features H.J. Lu via Libc-alpha
2020-09-18 16:07 ` [PATCH 4/4] ld.so: Add --list-tunables to print tunable values H.J. Lu via Libc-alpha
2020-09-21 8:25 ` Florian Weimer via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c877b04b-d80f-9c4d-03c8-3fa972b6a4b0@sourceware.org \
--to=libc-alpha@sourceware.org \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).