From: Martin Sebor via Libc-alpha <libc-alpha@sourceware.org>
To: "Martin Liška" <mliska@suse.cz>,
"GNU C Library" <libc-alpha@sourceware.org>
Subject: Re: [RFC patch] avoid warning on accesses to hardwired address
Date: Mon, 16 Aug 2021 09:24:02 -0600 [thread overview]
Message-ID: <c5d2f02e-4bb3-f35d-695d-7b97b2fbdf20@gmail.com> (raw)
In-Reply-To: <df3e9674-5d5f-0e7c-165d-2b31e5bb9b79@suse.cz>
On 8/16/21 5:27 AM, Martin Liška wrote:
> Hello.
>
> Small note here, the patch is incomplete as i386 target still fails:
The Glibc patch I submitted wasn't approved and I haven't implemented
the GCC change yet to handle named address spaces specially. It's on
my radar but will take some time to resolve.
Martin
>
> [ 96s] cc1: all warnings being treated as errors
> [ 96s] make[2]: *** [../o-iterator.mk:9:
> /home/abuild/rpmbuild/BUILD/glibc-2.34.9000.39.g6e8a0aac2f/cc-base/intl/loadmsgcat.o]
> Error 1
> [ 96s] make[2]: *** Waiting for unfinished jobs....
> [ 96s] In file included from ../sysdeps/i386/i686/nptl/tls.h:33,
> [ 96s] from ../sysdeps/generic/libc-tsd.h:44,
> [ 96s] from ../include/../locale/localeinfo.h:224,
> [ 96s] from ../include/ctype.h:26,
> [ 96s] from loadmsgcat.c:29:
> [ 96s] loadmsgcat.c: In function '_nl_load_domain':
> [ 96s] ../sysdeps/i386/nptl/tls.h:239:4: error: array subscript 0 is
> outside array bounds of '__seg_gs struct pthread * __seg_gs[0]'
> [-Werror=array-bounds]
> [ 96s] 239 | (*(struct pthread *__seg_gs *) offsetof (struct
> pthread, header.self))
> [ 96s] |
> ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [ 96s] ../sysdeps/nptl/libc-lock.h:92:18: note: in expansion of macro
> 'THREAD_SELF'
> [ 96s] 92 | void *self =
> THREAD_SELF; \
> [ 96s] | ^~~~~~~~~~~
> [ 96s] loadmsgcat.c:770:3: note: in expansion of macro
> '__libc_lock_lock_recursive'
> [ 96s] 770 | __libc_lock_lock_recursive (lock);
> [ 96s] | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
prev parent reply other threads:[~2021-08-16 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 0:55 [RFC patch] avoid warning on accesses to hardwired address Martin Sebor via Libc-alpha
2021-07-09 6:34 ` Florian Weimer via Libc-alpha
2021-07-21 13:06 ` Florian Weimer via Libc-alpha
2021-07-21 16:17 ` Martin Sebor via Libc-alpha
2021-08-16 11:27 ` Martin Liška
2021-08-16 15:24 ` Martin Sebor via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5d2f02e-4bb3-f35d-695d-7b97b2fbdf20@gmail.com \
--to=libc-alpha@sourceware.org \
--cc=mliska@suse.cz \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).