From: Paul Eggert <eggert@cs.ucla.edu>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org, carlos@redhat.com, joseph@codesourcery.com
Subject: Re: [PATCH] Drop dependency of dist target on ChangeLog
Date: Wed, 8 Jan 2020 17:56:23 -0800 [thread overview]
Message-ID: <c5162886-f42e-e902-7b0b-98066c49ec97@cs.ucla.edu> (raw)
In-Reply-To: <20200108085326.93010-1-siddhesh@sourceware.org>
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
This looks good, except for the change to timezone/README:
> +Please check the ChangeLog files in ChangeLog.old directory at the top level
> +for the version of the tzcode and tzdata packages.
It's awkward to have to paw through ChangeLog.old for version numbers,
plus when I took the trouble to actually do that I found that the
version numbers there were incorrect. So I propose the attached patch
instead.
[-- Attachment #2: 0001-Update-timezone-README.patch --]
[-- Type: text/x-patch, Size: 2111 bytes --]
From 3c69ed681a2a2a290fabad120137d20d379a03dc Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 8 Jan 2020 17:48:49 -0800
Subject: [PATCH] Update timezone/README
* timezone/version: New file, also taken from tzcode2018i.
* timezone/README: Reword so that people needn't paw through
old ChangeLog files to see which version we're using, a process
that is error-prone. Update an obsolescent URL.
---
timezone/README | 14 ++++++++------
timezone/version | 1 +
2 files changed, 9 insertions(+), 6 deletions(-)
create mode 100644 timezone/version
diff --git a/timezone/README b/timezone/README
index fc50f1399f..da814e3bca 100644
--- a/timezone/README
+++ b/timezone/README
@@ -1,6 +1,7 @@
The files
- zic.c zdump.c tzfile.h private.h tzselect.ksh
+ zic.c zdump.c tzfile.h private.h tzselect.ksh version
come from the tzcode package by Arthur David Olson et.al.
+The 'version' file specifies which tzcode version was used.
The files
africa antarctica asia australasia europe
@@ -8,14 +9,15 @@ The files
backward systemv solar87 solar88 solar89
iso3166.tab zone.tab leapseconds yearistype
come from the tzdata package by Arthur David Olson et.al.
-
-Please check the ChangeLog files in the top level directory for the
-version of the tzcode and tzdata packages.
+except that its 'yearistype.sh' file is renamed to 'yearistype'.
+These tzdata files were taken from tzdata 2009i and have not been
+updated since, as they do not affect a glibc installation and are
+present only for regression testing.
Please also see: https://sourceware.org/glibc/wiki/SharedSourceFiles
-These packages may be found at ftp://ftp.iana.org/tz/releases/. Commentary
-should be addressed to tz@iana.org.
+These packages may be found at https://ftp.iana.org/tz/releases/.
+Commentary should be addressed to tz@iana.org.
The subdirectory testdata contains manually edited data files for
regression testing purposes.
diff --git a/timezone/version b/timezone/version
new file mode 100644
index 0000000000..63f58006ee
--- /dev/null
+++ b/timezone/version
@@ -0,0 +1 @@
+2018i
--
2.24.1
next prev parent reply other threads:[~2020-01-09 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 8:53 [PATCH] Drop dependency of dist target on ChangeLog Siddhesh Poyarekar
2020-01-09 1:56 ` Paul Eggert [this message]
2020-01-09 2:01 ` Jonathan Nieder
2020-01-09 2:42 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5162886-f42e-e902-7b0b-98066c49ec97@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).