From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5074C1F55A for ; Fri, 21 Feb 2020 14:34:29 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=ZqgItZ/Y0XCWqgt2 +fuE5hMtXTkJo7/EyHFWSVNCgkcDf/pv6L1Lm+CB4GusFl8So5XWZBgh7r6mkKWk UnLF8uIgfHTGiSkGTLXcXFZSmJSSAxYRIULRlBXFzUhGD58wxBDM8ynqoZxWG88R MvnDjmwj/Lfnx/kWbE7zCXyFUsw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=Z0SK5SO9kGT9PAnlby3jzB Rnc5k=; b=wunYZ30L42sxfOGm2dqbjAqOojQaOOWKscGds0q87qXCmlVZvr2lzw vdSOm/I/MBUim+rabfnsQfSwCfkIwkaQ00VrnuSFwvdfKycXEPnEBZW8bpI4Ha2P AEuDUH0eWsorYYM1E0Z+IcHuGvdzxhd1tmyK9elD9p2LvZQ4i3P7g= Received: (qmail 97073 invoked by alias); 21 Feb 2020 14:34:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 97063 invoked by uid 89); 21 Feb 2020 14:34:26 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH 4/7] ldbl-128ibm-compat: fixup subdir location of several funcs To: libc-alpha@sourceware.org References: <20200214161051.32579-1-murphyp@linux.vnet.ibm.com> <20200214161051.32579-5-murphyp@linux.vnet.ibm.com> From: Paul E Murphy Message-ID: Date: Fri, 21 Feb 2020 08:34:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200214161051.32579-5-murphyp@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit While it was tested against build-many-glibcs.py, this doesn't actually build yet. I tested this locally for whatever that is worth. Pushed typo fix in comments: "it's" -> "its". On 2/14/20 10:10 AM, Paul E. Murphy wrote: > We want to ensure that if a second file is built to support > ieee128 long double, we built it's companion implementation > with ibm128 long double. The shared object versions of these > files build correctly because the aliasing is sufficiently > complex to prevent the redirects from applying when defining > them. > > However, this does not prevent the static object variants > from becoming quietly broken due to redirects. This is > intentionally avoided by marking such objects to be built > with -mabi=ibmlongdouble. > > Shuffle the misplaced routines to build against the subdir > which defines the needed symbols. > --- > sysdeps/ieee754/ldbl-128ibm-compat/Makefile | 32 ++++++++++----------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile > index 2dceb658e7..e40ae08469 100644 > --- a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile > +++ b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile