From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RDNS_NONE,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 8F9C81F4B4 for ; Wed, 20 Jan 2021 14:16:14 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20A613954C73; Wed, 20 Jan 2021 14:16:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20A613954C73 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611152173; bh=oiEVfaQo1o6kCimflvyai09GRUxpYnyfG40xdLMWVHE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vCvB1Z9tlz9iE83uhvdv8c7xgm4jkEuyGLLeTtlkE3k+4aribxv/eJWugAnjSlycB tvha/HrWhWf6MEQ0jrC/+AjPXA2C0KDAbvKiOzwvFj2NPmr7ni1/XBz0w7rl3HUnit f2dIp8k623baeVmOH6VluuMl1hX7fxyEx5OeKEPM= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 49B2A3857805 for ; Wed, 20 Jan 2021 14:16:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 49B2A3857805 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-cMjWfrfIMtq9PkXC-_T5fQ-1; Wed, 20 Jan 2021 09:16:07 -0500 X-MC-Unique: cMjWfrfIMtq9PkXC-_T5fQ-1 Received: by mail-qt1-f198.google.com with SMTP id w5so10149180qts.9 for ; Wed, 20 Jan 2021 06:16:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oiEVfaQo1o6kCimflvyai09GRUxpYnyfG40xdLMWVHE=; b=ORTFNtH+9ick8jgXsQY8z+QV70lmyscD8pkQ5hil/2vS+mLROvXqUue3qmfFbq3RkG OoWHCgGe8Q1LjA96PLtqR4BZjTbH3/uaiDCBZhkjqkUxG/SUOhh3pLSNbqEZyl9uonPB zKXI/g3eRjx+ETPLUMb3uEiIJ9RFok7J1zZIw7W9EJn74tHkJH+6g9vIbY0Phlc+xJOJ xticRFHFhybElWzNtA7smlrLYewCR+B7ljY3zABFV8Os28iH7o9l7OymO9BeJzs229AO xGxqh/To934iKiHNRm2DbOLQrPaSOHYPXLu1wFfjxxxYOkgERteoLXZYQK2+u5mZPbkc fQXA== X-Gm-Message-State: AOAM531HpKMz60OLqudRNhUIAnaBrT6qmqY8XGA7txb4UL8IjAGGB0ou FejbPHWK5nK7ZZj4P9IY18v9V8oX006b2vu0fy8DyLlg6d8UNMsj4XAGQKZc4J9ggvp6H29Brys 2T7BzDg/CyHx8YhsQ3oNp X-Received: by 2002:a0c:f48a:: with SMTP id i10mr9379523qvm.61.1611152167018; Wed, 20 Jan 2021 06:16:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGm78vGrwL1c5QZlAUrL2hzrWdFXVgIFY69xrM52UsAxMw6aL9DRRnHrg3EZdre56cJ7XrIA== X-Received: by 2002:a0c:f48a:: with SMTP id i10mr9379510qvm.61.1611152166858; Wed, 20 Jan 2021 06:16:06 -0800 (PST) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id r20sm1273837qke.92.2021.01.20.06.16.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 06:16:06 -0800 (PST) Subject: Re: V8 [PATCH] sysconf: Add _SC_MINSIGSTKSZ/_SC_SIGSTKSZ [BZ #20305] To: "H.J. Lu" , Florian Weimer References: <20201104165018.GE6882@arm.com> <87lfeyvghf.fsf@mid.deneb.enyo.de> <20201118170434.GF6882@arm.com> <873616va9n.fsf@mid.deneb.enyo.de> <20201118180927.GI6882@arm.com> <87tutkjexc.fsf@mid.deneb.enyo.de> Organization: Red Hat Message-ID: Date: Wed, 20 Jan 2021 09:16:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Cc: "H.J. Lu via Libc-alpha" , Dave Martin , Joseph Myers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 11/20/20 6:13 PM, H.J. Lu via Libc-alpha wrote: > On Fri, Nov 20, 2020 at 6:12 AM Florian Weimer wrote: >> >> * H. J. Lu: >> >>> Can we reach a consensus for _GNU_SOURCE vs _SC_SIGSTKSZ_SOURCE? >>> >>> How about we make _GNU_SOURCE to enable _SC_SIGSTKSZ_SOURCE and >>> check _SC_SIGSTKSZ_SOURCE != 0? If _GNU_SOURCE triggers compilation >>> error and source codes can't be changed, we can add >>> -D_SC_SIGSTKSZ_SOURCE=0 to disable _SC_SIGSTKSZ_SOURCE. >> >> I think the source code compatibility is much more obscure than the >> other things we broke quite recently, even without deprecation. Why >> do we add the complexity in this case? I feel it is disproportional. > > Here is the patch with _GNU_SOURCE. Any comments? (1) New version of patch. This patch no longer compiles due to __cpuid_count errors. Could you please update this and post a v9? This is ABI addition for the constants so I want to make sure I review something that works and is final from your end. (2) Kernel definition of constant for AT_MINSIGSTKSZ? We don't have a released kernel for x86 with this constant defined? The kernel patch was only just updated 5 days ago: https://sourceware.org/pipermail/libc-alpha/2021-January/121671.html Doesn't this mean this patch is inappropriate for glibc 2.33? -- Cheers, Carlos.