Re: [PATCH v2 11/30] ldbl-128ibm-compat: Add error.h functions

[Paul E Murphy <murphyp@linux.ibm.com>]

On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
> 
> No changes since v1.
> 
> -- 8< --
> Use the recently added, internal functions, __error_at_line_internal and
> __error_internal, to provide error.h functions that can take long double
> arguments with IEEE binary128 format on platforms where long double can
> also take double format or some non-IEEE format (currently, this means
> powerpc64le).
> 
> Tested for powerpc64le.
> ---
>   misc/errorP.h                                 | 28 ++++++++++
>   sysdeps/ieee754/ldbl-128ibm-compat/Makefile   |  3 +-
>   sysdeps/ieee754/ldbl-128ibm-compat/Versions   |  3 ++
>   .../ldbl-128ibm-compat/ieee128-error.c        | 51 +++++++++++++++++++
>   4 files changed, 84 insertions(+), 1 deletion(-)
>   create mode 100644 misc/errorP.h
>   create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/ieee128-error.c
> 
> diff --git a/misc/errorP.h b/misc/errorP.h
> new file mode 100644
> index 0000000000..c61c49cd61
> --- /dev/null
> +++ b/misc/errorP.h
> @@ -0,0 +1,28 @@
> +/* Prototypes for internal error.h functions.
> +   Copyright (C) 2018 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#include <stdarg.h>
> +
> +void
> +__error_internal (int status, int errnum, const char *message,
> +		  va_list args, unsigned int mode_flags);
> +
> +void
> +__error_at_line_internal (int status, int errnum, const char *file_name,
> +			  unsigned int line_number, const char *message,
> +			  va_list args, unsigned int mode_flags);

A similar question to patch 10 in this series. These declarations appear 
in include/error.h too.

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Versions b/sysdeps/ieee754/ldbl-128ibm-compat/Versions

OK.

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/ieee128-error.c b/sysdeps/ieee754/ldbl-128ibm-compat/ieee128-error.c

OK.