From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AC0A51F8C6 for ; Tue, 10 Aug 2021 13:21:38 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 44718395ACD0 for ; Tue, 10 Aug 2021 13:21:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 44718395ACD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628601697; bh=y/m3gb0SkUaDudWamWKqlfIIDN6C8iFMW3YwjAyLBLA=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=yiTBSA/ijs3flMDOqJYr3B8x+LA9wHgj5X7j1vrcusBSM1eAuAYctepww+gBdp5gN IL8RvgFRr9bWEe3ggVsTRSno4eez6Na/ohqwJ1eljpW9qTK+OmCto+PGIeDW3iT7q9 qiXs3h6Y9EG6sxHceYi2T/hrujszxm45qPifQOis= Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id F3F193857C65 for ; Tue, 10 Aug 2021 13:21:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3F193857C65 Received: by mail-pl1-x629.google.com with SMTP id l11so9306750plk.6 for ; Tue, 10 Aug 2021 06:21:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y/m3gb0SkUaDudWamWKqlfIIDN6C8iFMW3YwjAyLBLA=; b=iAYk8YQ1Tu8Za320Toxmj8gt37BLLx51cKFGHoUOkpObI4wrPHy5JBO/9jrXCKpxxb oHAjn6kopxK/qI6IGet/jdk+VOk7AslpdOIgTnDgR6mfxSpSAHXnDPw3G+UIxPbCIGGK Lqgy0zl/sOycQ+6BwwjLNK9fnw3K7L5aolotUZpZq/+xnfOIg0WgavMfqSs7gKVQd5xN LgR829bjvpAwZDLs0G4SBWJvUn8AnY/mltVmlrFZehVCxvEK3bLo4VVPo3y0gtbRhVwQ sQXBbGtvBbt/Y56F/KdNi7DHcCiapo0TjdRGe3bTMEqDs3Wy0LD/9ZLUN7+/uBULMi0T kn/Q== X-Gm-Message-State: AOAM532nxsWTB/caztXZvVZEy9fal7J4QtcHxxGPfjGhHw6NS5ArJS+m jlV4ZgAagjuSaODVWiQQIQPpUQ== X-Google-Smtp-Source: ABdhPJzCzVaXem9ZtDXMkaOcDjIxsmulKh2i4PuIUA0Qy6/0+NZQci6ZwiiwFhnKXi1iUHUfDOU34Q== X-Received: by 2002:a17:90b:1bca:: with SMTP id oa10mr33023564pjb.177.1628601667135; Tue, 10 Aug 2021 06:21:07 -0700 (PDT) Received: from ?IPv6:2804:431:c7cb:9dce:5752:5b5a:453:cdda? ([2804:431:c7cb:9dce:5752:5b5a:453:cdda]) by smtp.gmail.com with ESMTPSA id h7sm22272522pjs.38.2021.08.10.06.21.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 06:21:06 -0700 (PDT) Subject: Re: [RFC][PATCH v12 4/8] Add DT_GNU_FLAGS_1/DF_GNU_1_UNIQUE to glibc DSOs (bug 22745) To: libc-alpha@sourceware.org, Vivek Das Mohapatra References: <20210708163255.812-1-vivek@collabora.com> <20210708163255.812-5-vivek@collabora.com> <6209df75-2d78-b188-4041-fe77849e224c@linaro.org> Message-ID: Date: Tue, 10 Aug 2021 10:21:04 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <6209df75-2d78-b188-4041-fe77849e224c@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" There are a couple of minor issues that prevent the -Wl,-z,unique usage. It does not change the build outcome because the the unique GNU_FLAGS_1 will be added by elf/dynamic-notes.os anyway. > On 08/07/2021 13:32, Vivek Das Mohapatra via Libc-alpha wrote: >> diff --git a/config.make.in b/config.make.in >> index cbf59114b0..8755490c13 100644 >> --- a/config.make.in >> +++ b/config.make.in >> @@ -72,6 +72,7 @@ have-cc-with-libunwind = @libc_cv_cc_with_libunwind@ >> fno-unit-at-a-time = @fno_unit_at_a_time@ >> bind-now = @bindnow@ >> have-hash-style = @libc_cv_hashstyle@ >> +ld-zunique = @ld_zunique@ This is wrong, it should be '@libc_cv_ld_zunique@' >> diff --git a/configure.ac b/configure.ac >> index 34ecbba540..9369bcbebe 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -1372,9 +1372,28 @@ fi >> rm -f conftest*]) >> AC_SUBST(libc_cv_hashstyle) >> >> +AC_CACHE_CHECK([for linker DT_GNU_FLAGS_1/ DF_GNU_1_UNIQUE support], > > Maybe a space before ' /'. > >> + libc_cv_ld_zunique, [dnl >> +cat > conftest.ld.c <<\EOF >> +int x (void) { return 0; } >> +EOF >> + >> +libc_cv_ld_zunique=no; >> + >> +if AC_TRY_COMMAND([dnl >> +${CC-cc} -Wl,--fatal-warnings -Wl,-z,unique -shared -o conftest.ld.so conftest.ld.c]) >> +then >> + libc_cv_ld_zunique=yes >> +fi; >> +ld_zunique=$libc_cv_ld_zunique >> +rm -f conftest*]) >> +AC_SUBST(ld_zunique) This is wrong, it should be AC_SUBST(libc_cv_ld_zunique).