From: "Alejandro Colomar \(man-pages\) via Libc-alpha" <libc-alpha@sourceware.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Marek Behún" <kabel@kernel.org>,
"G. Branden Robinson" <g.branden.robinson@gmail.com>,
libc-alpha@sourceware.org,
"Michael Kerrisk" <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org
Subject: Re: [PATCH] ioctl_tty.2: Add example how to get or set baudrate on the serial port
Date: Fri, 30 Jul 2021 13:47:06 +0200 [thread overview]
Message-ID: <b8ef8f70-ae61-b0f1-58dc-37380ae242ee@gmail.com> (raw)
In-Reply-To: <20210730095333.6118-1-pali@kernel.org>
Hi Pali,
On 7/30/21 11:53 AM, Pali Rohár wrote:
> Signed-off-by: Pali Rohár <pali@kernel.org>
Thanks for the patch!
Please see some comments below.
Cheers,
Alex
> ---
> man2/ioctl_tty.2 | 60 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
>
> diff --git a/man2/ioctl_tty.2 b/man2/ioctl_tty.2
> index 0b0083c671a7..9d394572ae93 100644
> --- a/man2/ioctl_tty.2
> +++ b/man2/ioctl_tty.2
> @@ -750,6 +750,66 @@ main(void)
> close(fd);
> }
> .EE
> +.PP
> +Get or set arbitrary baudrate on the serial port.
> +.PP
> +.EX
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <sys/types.h>
> +#include <fcntl.h>
> +#include <unistd.h>
> +#include <sys/ioctl.h>
> +#include <asm/termbits.h>
Unless there's a reason to use a specific include order (and if so, add
a comment), please use alphabetical order.
> +
> +int
> +main(int argc, char *argv[])
> +{
> +#if !defined(TCGETS2) || !defined(TCSETS2) || !defined(BOTHER)
> + fprintf(stderr, "TCGETS2, TCSETS2 or BOTHER is unsupported\\n");
> + return 1;
> +#else
Do we want the program to compile if those are unsupported?
Maybe you can #error there and simplify the reader having to parse the
preprocessor directive mentally:
#if !defined...
# error ...
#endif
I know it's non-standard, but I think it's common enough so that we can
use it here.
> + struct termios2 tio2;
> + int fd, rc;
> +
> + if (argc != 2 && argc != 3) {
> + fprintf(stderr, "Usage: %s device [new_baudrate]\\n", argv[0]);
We use \e for printing the escape character. Not \\
CC: Branden
See groff_man(7):
Portability
[...]
Similar caveats apply to escapes. Some escape sequences
are however required for correct typesetting even in man
pages and usually do not cause portability problems:
[...]
\e Widely used in man pages to represent a backslash
output glyph. It works reliably as long as the .ec
request is not used, which should never happen in
man pages, and it is slightly more portable than the
more exact ‘\(rs’ (“reverse solidus”) escape se‐
quence.
> + return 1;
> + }
> +
> + fd = open(argv[1], O_RDWR | O_NONBLOCK | O_NOCTTY);
> + if (fd < 0) {
> + perror("open");
> + return 1;
exit(EXIT_FAILURE);
> + }
> +
> + rc = ioctl(fd, TCGETS2, &tio2);
> + if (rc) {
> + perror("TCGETS2");
> + close(fd);
> + return 1;
exit(3)
> + }
> +
> + printf("%u\\n", tio2.c_ospeed);
\e
> +
> + if (argc == 3) {
> + tio2.c_cflag &= ~CBAUD;
> + tio2.c_cflag |= BOTHER;
> + tio2.c_ospeed = tio2.c_ispeed = atoi(argv[2]);
> +
> + rc = ioctl(fd, TCSETS2, &tio2);
> + if (rc) {
> + perror("TCSETS2");
> + close(fd);
> + return 1;
exit(3)
> + }
> + }
> +
> + close(fd);
> + return 0;
exit(3)
> +#endif
> +}
> +.EE
> .SH SEE ALSO
> .BR ldattach (1),
> .BR ioctl (2),
>
--
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
next prev parent reply other threads:[~2021-07-30 11:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 9:53 [PATCH] ioctl_tty.2: Add example how to get or set baudrate on the serial port Pali Rohár via Libc-alpha
2021-07-30 11:47 ` Alejandro Colomar (man-pages) via Libc-alpha [this message]
2021-07-30 12:05 ` Pali Rohár via Libc-alpha
2021-07-30 12:21 ` Alejandro Colomar (man-pages) via Libc-alpha
2021-07-30 13:02 ` [PATCH v2] " Pali Rohár via Libc-alpha
2021-08-01 13:51 ` [PATCH v3] " Pali Rohár via Libc-alpha
2021-08-04 22:08 ` Pali Rohár via Libc-alpha
2021-08-05 5:52 ` Greg Kroah-Hartman via Libc-alpha
2021-08-05 8:22 ` Pali Rohár via Libc-alpha
2021-08-05 8:30 ` Greg Kroah-Hartman via Libc-alpha
2021-08-05 8:44 ` Pali Rohár via Libc-alpha
2021-08-05 8:50 ` Greg Kroah-Hartman via Libc-alpha
2021-08-05 9:51 ` Pali Rohár via Libc-alpha
2021-08-05 15:28 ` Alejandro Colomar (man-pages) via Libc-alpha
2021-08-05 16:14 ` Greg Kroah-Hartman via Libc-alpha
2021-08-05 16:45 ` Licensing example programs in man-pages (was [PATCH v3] ioctl_tty.2: Add example how to get or set baudrate on the serial port) Alejandro Colomar (man-pages) via Libc-alpha
2021-08-05 17:54 ` Greg Kroah-Hartman via Libc-alpha
2021-08-06 7:22 ` Alejandro Colomar (man-pages) via Libc-alpha
2021-08-06 8:32 ` Pali Rohár via Libc-alpha
2021-08-08 8:35 ` [PATCH v3] ioctl_tty.2: Add example how to get or set baudrate on the serial port Alejandro Colomar (man-pages) via Libc-alpha
2021-08-08 21:05 ` Pali Rohár via Libc-alpha
2021-08-08 21:19 ` Alejandro Colomar (man-pages) via Libc-alpha
2021-08-10 19:49 ` [PATCH v4] " Pali Rohár via Libc-alpha
2021-08-10 20:11 ` Pali Rohár via Libc-alpha
2021-08-31 20:34 ` Pali Rohár via Libc-alpha
2021-09-10 13:37 ` Alejandro Colomar (man-pages) via Libc-alpha
2021-09-10 13:39 ` Pali Rohár via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8ef8f70-ae61-b0f1-58dc-37380ae242ee@gmail.com \
--to=libc-alpha@sourceware.org \
--cc=alx.manpages@gmail.com \
--cc=g.branden.robinson@gmail.com \
--cc=kabel@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).