From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix buffer overrun in EUC-KR conversion module (bug 24973)
Date: Mon, 9 Sep 2019 14:16:48 -0300 [thread overview]
Message-ID: <b771bfee-2ab5-9c6d-bf4e-162112b47257@linaro.org> (raw)
In-Reply-To: <mvmftl5sbqj.fsf@suse.de>
On 09/09/2019 12:58, Andreas Schwab wrote:
> diff --git a/iconvdata/euc-kr.c b/iconvdata/euc-kr.c
> index 379414c426..167a554719 100644
> --- a/iconvdata/euc-kr.c
> +++ b/iconvdata/euc-kr.c
> @@ -83,7 +83,7 @@ euckr_from_ucs4 (uint32_t ch, unsigned char *cp)
> /* 0xfe(->0x7e : row 94) and 0xc9(->0x59 : row 41) are \
> user-defined areas. */ \
> else if (__builtin_expect (ch == 0xa0, 0) \
> - || __builtin_expect (ch > 0xfe, 0) \
> + || __builtin_expect (ch >= 0xfe, 0) \
> || __builtin_expect (ch == 0xc9, 0)) \
> { \
> /* This is illegal. */ \
>
We should aim to use __glibc_{un}likely for new code.
next prev parent reply other threads:[~2019-09-09 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 15:58 [PATCH] Fix buffer overrun in EUC-KR conversion module (bug 24973) Andreas Schwab
2019-09-09 17:16 ` Adhemerval Zanella [this message]
2019-09-10 9:08 ` [PATCH v2] " Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b771bfee-2ab5-9c6d-bf4e-162112b47257@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).