From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id CC7461F4B4 for ; Mon, 5 Oct 2020 19:46:18 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 93049394D82F; Mon, 5 Oct 2020 19:46:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93049394D82F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1601927177; bh=RQlCv455+dmHCDgYT3FVMqGJR7CmCk8pcE2ucoMfszI=; h=To:References:Subject:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=xOBcrdGYBxOeQxxeooxlvyUPoEGmwfRUXaZy6txuvRDhxUl2H7lBNvtxT8FJDXj31 qmqvpFyFCoDyZUcwdG7n0KlW6GJjazaEeSMqUx1Far96DrwQWWC/kKQsZpZoD3pMBz AYU1uRDaFbh6jDMF3262ICeUv0lQRYWCsgS2uY5I= Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by sourceware.org (Postfix) with ESMTPS id B7FB83950C01 for ; Mon, 5 Oct 2020 19:46:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B7FB83950C01 Received: by mail-qk1-x744.google.com with SMTP id y198so7105428qka.0 for ; Mon, 05 Oct 2020 12:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RQlCv455+dmHCDgYT3FVMqGJR7CmCk8pcE2ucoMfszI=; b=lMy96Q5mk5uR6d+dzgnLpbReZoMP9i0JvEuvihCTaMw7o8hxzboleGNQuTmzpSq5ow wvCOmdYngL36dP7y4v6PlW3Sq6tO2TedzpYaBTcImPftE619uReYQgffabvD2Xdfz3Yc UZkAOy/8UzpNSQvrq66s4LPJ6lZLisZIRRHIpanF4OoMM3ka/L4yedR8pzBhiTiY/0cJ KEoY7T0MZCFtRQcqLPu/cnxzknz87Y3DNdXkZ2VaTeKbZFo8HtwlEuyr206zyE5bNLfS Y3bfzX4esRucPBjyTZBuYQ4gayNGP+O730sG4y/O6pS8BUyZijs6jwMUdC8+QyVCqlqW BjRg== X-Gm-Message-State: AOAM533wniA9A3EcVulRKdKru+KAxdgdlRqrG/pXMCdvs39r0ct9ShSN UprW4Buqgd1JQnjREum0Qa3AeQ== X-Google-Smtp-Source: ABdhPJw9KdjCvVPYM8YLb+KUeIS9qAZyoHBtq580lEeuYaeHdNscNPXpQ9IbU5tlJfa6CmemTysKfw== X-Received: by 2002:a05:620a:661:: with SMTP id a1mr1729679qkh.92.1601927173174; Mon, 05 Oct 2020 12:46:13 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id d10sm775696qkk.1.2020.10.05.12.46.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Oct 2020 12:46:12 -0700 (PDT) To: libc-alpha@sourceware.org, Florian Weimer References: <5b4f6b0bb9305266ddc5f4878ac63bc80b3a9be7.1601569371.git.fweimer@redhat.com> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 03/28] elf: Implement _dl_write Message-ID: Date: Mon, 5 Oct 2020 16:46:09 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5b4f6b0bb9305266ddc5f4878ac63bc80b3a9be7.1601569371.git.fweimer@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 01/10/2020 13:31, Florian Weimer via Libc-alpha wrote: > The generic version is parallel to _dl_writev. It cannot use > _dl_writev directly because the errno value needs to be obtained > under a lock. I think we can in fact replace the _dl_writev usage by _dl_write with a bonus of a possible code size reduction (since it will be replace by a function call). LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > elf/Makefile | 2 +- > elf/dl-write.c | 56 ++++++++++++++++++++++++++++++ > sysdeps/generic/ldsodefs.h | 6 ++++ > sysdeps/unix/sysv/linux/dl-write.c | 30 ++++++++++++++++ > 4 files changed, 93 insertions(+), 1 deletion(-) > create mode 100644 elf/dl-write.c > create mode 100644 sysdeps/unix/sysv/linux/dl-write.c > > diff --git a/elf/Makefile b/elf/Makefile > index e0a8bf2998..ab792d45c2 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -34,7 +34,7 @@ dl-routines = $(addprefix dl-,load lookup object reloc deps \ > version profile tls origin scope \ > execstack open close trampoline \ > exception sort-maps lookup-direct \ > - call-libc-early-init) > + call-libc-early-init write) > ifeq (yes,$(use-ldconfig)) > dl-routines += dl-cache > endif Ok. > diff --git a/elf/dl-write.c b/elf/dl-write.c > new file mode 100644 > index 0000000000..7350aff003 > --- /dev/null > +++ b/elf/dl-write.c > @@ -0,0 +1,56 @@ > +/* Implementation of the _dl_write function. Generic version. > + Copyright (C) 2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > +#include > + > +ssize_t > +_dl_write (int fd, const void *buffer, size_t length) > +{ > + struct iovec iov = { .iov_base = (void *) buffer, .iov_len = length }; > + ssize_t ret; > + > +#if RTLD_PRIVATE_ERRNO > + /* We have to take this lock just to be sure we don't clobber the private > + errno when it's being used by another thread that cares about it. > + Yet we must be sure not to try calling the lock functions before > + the thread library is fully initialized. */ > + if (__glibc_unlikely (_dl_starting_up)) > + { > + ret = __writev (fd, &iov, 1); > + if (ret < 0) > + ret = -errno; > + } > + else > + { > + __rtld_lock_lock_recursive (GL(dl_load_lock)); > + __writev (fd, &iov, 1); > + if (ret < 0) > + ret = -errno; > + __rtld_lock_unlock_recursive (GL(dl_load_lock)); > + } > +#else > + ret = __writev (fd, &iov, 1); > + if (ret < 0) > + ret = -errno; > +#endif > + > + return ret; > +} Ok. > diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h > index ba114ab4b1..7cb1fccc80 100644 > --- a/sysdeps/generic/ldsodefs.h > +++ b/sysdeps/generic/ldsodefs.h > @@ -757,6 +757,12 @@ _dl_dprintf (int fd, const char *fmt, ...) > } > #endif > > +/* Write LENGTH bytes at BUFFER to FD, like write. Returns the number > + of bytes written on success, or a negative error constant on > + failure. */ > +ssize_t _dl_write (int fd, const void *buffer, size_t length) > + attribute_hidden; > + > /* Write a message on the specified descriptor standard output. The > parameters are interpreted as for a `printf' call. */ > void _dl_printf (const char *fmt, ...) Ok. > diff --git a/sysdeps/unix/sysv/linux/dl-write.c b/sysdeps/unix/sysv/linux/dl-write.c > new file mode 100644 > index 0000000000..1c6298fb41 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/dl-write.c > @@ -0,0 +1,30 @@ > +/* Implementation of the _dl_write function. Linux version. > + Copyright (C) 2020 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > +#include > + > +ssize_t > +_dl_write (int fd, const void *buffer, size_t length) > +{ > + long int r = INTERNAL_SYSCALL_CALL (write, fd, buffer, length); > + if (INTERNAL_SYSCALL_ERROR_P (r)) > + r = - INTERNAL_SYSCALL_ERRNO (r); > + return r; > +} > Ok.