From: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
To: Carlos O'Donell <codonell@redhat.com>,
Krzysztof Koch <Krzysztof.Koch@arm.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH] Add new script for plotting string benchmark JSON output
Date: Wed, 13 Nov 2019 14:20:45 +0000 [thread overview]
Message-ID: <b5553150-8a22-13f2-fdec-a67e5c602a31@arm.com> (raw)
In-Reply-To: <76308bc1-ee72-6422-e39b-52586503cd8c@redhat.com>
On 13/11/2019 13:57, Carlos O'Donell wrote:
> On 11/13/19 6:57 AM, Krzysztof Koch wrote:
>> Add a script for visualizing the JSON output generated by existing
>> glibc string microbenchmarks.
>
> This is really awesome!
>
>> Unfortunately, this information is not exposed in the benchmark output
>> file, so plot_strings.py has to resort to computing the geometric mean
>> of these multiple values. In the process, useful information about the
>> benchmark configuration is lost. Also, averaging the timings for
>> different alignments can hide useful characterstics of the benchmarked
>> ifuncs.
> That is fine. Not all forms of representation are capable of showing
> all nuances.
>
> I'm happy to see you commit this to master immediately.
>
> Krzysztof please lean on Szabolcs to get this committed :-)
ok, committed.
prev parent reply other threads:[~2019-11-13 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 11:57 [PATCH] Add new script for plotting string benchmark JSON output Krzysztof Koch
2019-11-13 13:57 ` Carlos O'Donell
2019-11-13 14:20 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5553150-8a22-13f2-fdec-a67e5c602a31@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=Krzysztof.Koch@arm.com \
--cc=codonell@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).