From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 71A801F601 for ; Fri, 2 Dec 2022 18:20:53 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="n0V5LyOf"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 488113858C20 for ; Fri, 2 Dec 2022 18:20:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 488113858C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670005251; bh=Pw46yOZwUQ7xvoRoc6z98atZcKADSvyG0M0VfI7oE+I=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=n0V5LyOfFa39Fxt0eh+zU5InB6IrUHzOCC9/82zaXK2Q6Jvs9NqfW+l17AFFWvle7 bt5ZYkrQtVN/qeaqoEZvk3QHb+dC1EdaWDaUw71fVctAvDGrt2/E7eztkHC0t8Lh50 niAVm4oIJwwUxukYhlcvPduYoJikWXpLXSenzLFY= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 14C1B3858C62 for ; Fri, 2 Dec 2022 18:20:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14C1B3858C62 Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-436-bP6I3UCRMMy1UvmIDPhIig-1; Fri, 02 Dec 2022 13:20:30 -0500 X-MC-Unique: bP6I3UCRMMy1UvmIDPhIig-1 Received: by mail-il1-f199.google.com with SMTP id l16-20020a056e02067000b0030325bbd570so6145495ilt.0 for ; Fri, 02 Dec 2022 10:20:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pw46yOZwUQ7xvoRoc6z98atZcKADSvyG0M0VfI7oE+I=; b=I33M16IBN2SP7+mBn4tEADAicZTe/xcBsnAgYEN1g4OyH/Y9hxxpxuMjkAqZz86DTI stVrN8whCiPXh0JTi0lU/P3lfUWoynniXhs6RxGmwxbjwnbIHXDsgXF9n9etgpb9UHUQ p3zIYwaDtK5YypH8/zalURmcO5fq5in29LHF1/1eYNCYEX+MxrjhuugEBWJDi2+AIFiy VtNlI0XcMYw1/s58BcKOp/1FGERl7m5guJ9IGq5f2DEM4f7XNwAq3VOIsQJI+4m96jwD 1bxwkjplBDa4epghMTr0GAsmb7dybnQE22fjQDO5gOkZBo8vKHYSaRQN5g5+C4ktwy+c yeog== X-Gm-Message-State: ANoB5pmz1gZcz6PZgdxzLJrBC9+GjsG8lTfUa2kgimeFaQub/8Bbju6H +lnVuASN5XIs1U/Bg0cqKLhZBovCQpiVTxlQM1eTFs449V4J0B2YUEFIQ+QGfgZn+qy+gJs5Q33 Caz+L/Sbdww6Z6oeec2XC X-Received: by 2002:a92:da8d:0:b0:302:e2a7:94fd with SMTP id u13-20020a92da8d000000b00302e2a794fdmr20531982iln.178.1670005229939; Fri, 02 Dec 2022 10:20:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf6Yvs8/IjmDB3RhFvAvaIr0vYGyhjvqIKYTDLDiKUyMOBBvbeJcF1lK7NZpl3GfKsNCG5uiNw== X-Received: by 2002:a92:da8d:0:b0:302:e2a7:94fd with SMTP id u13-20020a92da8d000000b00302e2a794fdmr20531977iln.178.1670005229718; Fri, 02 Dec 2022 10:20:29 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id z8-20020a05663822a800b00363fe31cf55sm2924322jas.40.2022.12.02.10.20.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 10:20:29 -0800 (PST) Message-ID: Date: Fri, 2 Dec 2022 13:20:27 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] elf: Fix rtld-audit trampoline for aarch64 To: Vladislav Khmelevsky , Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org, woodard@redhat.com References: <20221117084729.2794073-1-och95@yandex.ru> <8c6d9a21-464b-3b8d-661a-a3b3733e1bb7@linaro.org> <3180cd8a-a3e2-b6bb-cb6a-af7c2a4fca22@linaro.org> <8E908272-FB79-4940-9183-A705EDA36D05@yandex.ru> Organization: Red Hat In-Reply-To: <8E908272-FB79-4940-9183-A705EDA36D05@yandex.ru> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 11/17/22 13:51, Vladislav Khmelevsky via Libc-alpha wrote: > Thanks! But I would need some guidance from you if you don't mind. > First of all I don't have write access to the repo, I would very > appreciate if you or somebody would help me to merge this :) I was doing some review of rtld-audit changes we might want to backport, and I just wanted to close the loop here that this is committed to the glibc development branch as of November 21st and will be in glibc 2.37, and has already been backported all the way to glibc 2.34 (which introduced the key fixes for aarch64 in rtld-audit). We could have written a test case for this, but it's an odd testcase because it's about ensuring we touch minimal register state as we return through the pltexit case. Sending this email mostly for my own records so I remember what we did. -- Cheers, Carlos.