From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4BB941F8C6 for ; Fri, 2 Jul 2021 08:46:22 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2DB49397C858 for ; Fri, 2 Jul 2021 08:46:21 +0000 (GMT) Received: from beige.elm.relay.mailchannels.net (beige.elm.relay.mailchannels.net [23.83.212.16]) by sourceware.org (Postfix) with ESMTPS id 3A2733857C7E for ; Fri, 2 Jul 2021 08:46:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3A2733857C7E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E63AA321BAD; Fri, 2 Jul 2021 08:46:06 +0000 (UTC) Received: from pdx1-sub0-mail-a42.g.dreamhost.com (100-96-16-86.trex.outbound.svc.cluster.local [100.96.16.86]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A1059322C19; Fri, 2 Jul 2021 08:46:04 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a42.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.16.86 (trex/6.3.3); Fri, 02 Jul 2021 08:46:06 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Tangy-Cellar: 6259425b66b871ce_1625215566756_2300100837 X-MC-Loop-Signature: 1625215566756:4254058089 X-MC-Ingress-Time: 1625215566755 Received: from pdx1-sub0-mail-a42.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTP id 4BCD0897E3; Fri, 2 Jul 2021 08:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=B/++7V fxqDO7/uQK3jMMW73V07Y=; b=huzabqgt2bjtM9d46GCCAdbJME0z6MaRojAbaw xU8V0ppBKKOTK77X583VHG/ZDHj3xqnR/b4lN61D0ongUHO1cEJA24A+JnUSpnKq 5kaZ4UCzcHmlbzBtVRANv1rP7IfDgwfuwG9Roqr+85Zs+KiO1uZp3CfiG6GnEVlC Yxnw4= Received: from [192.168.1.136] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTPSA id E27ED897DF; Fri, 2 Jul 2021 08:46:01 +0000 (UTC) Subject: Re: [PATCH] Update tcache double-free check To: Eyal Itkin References: <22dd78e7-13a7-0bec-37ba-f3e32a9630ab@redhat.com> <5c6aa5c1-7962-6f05-a114-0d79c9cd9bc5@redhat.com> <0c7d951e-ef54-e521-535d-920ad76be33b@gotplt.org> X-DH-BACKEND: pdx1-sub0-mail-a42 From: Siddhesh Poyarekar Message-ID: Date: Fri, 2 Jul 2021 14:15:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , GNU C Library Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/2/21 1:27 PM, Eyal Itkin wrote: > Nice to see that this topic is still alive. As I said earlier, > although my initial patch was per-thread, my later analysis convinced > me that a per process solution will be a better idea. > > As for the benchmarking, the cost per-thread was negligible, so I > don't see any potential risk with using the same solution (getrandom > and all) just one time per process. OK that's great, thanks for confirming. > Sadly, I suggest you will modify my original patch / recreate a > similar solution, as I can no longer commit new code to FSF. In the > time passed the approval of my original employer has expired (approval > was for a single year) and I also switched work place and will have to > undergo the entire legal process yet again. I understand. > Given the maturity of the current draft, I suggest you will complete > this feature based on my contribution (contribution that was made when > it was still allowed). Without an additional similar feature in the > near future, I don't see the benefit in troubling a VP for signing > again the legal docs. > > Happy to see that this feature was not abandoned. > > Good luck to your all, and thanks for your enthusiasm for improving > the security of such an important library. No worries and thank you for sharing the idea and following up on it. I'll post a draft soon. Thanks, Siddhesh