From: "Martin Liška" <mliska@suse.cz>
To: DJ Delorie <dj@redhat.com>, Florian Weimer <fw@deneb.enyo.de>
Cc: libc-alpha@sourceware.org, schwab@linux-m68k.org
Subject: Re: [PATCH] Use size_t for mallinfo fields.
Date: Wed, 12 Aug 2020 14:29:32 +0200 [thread overview]
Message-ID: <b2f0cfa0-a348-e2bb-b3b6-f56454075f76@suse.cz> (raw)
In-Reply-To: <xnmu31p0tg.fsf@greed.delorie.com>
On 8/11/20 7:08 PM, DJ Delorie wrote:
> Florian Weimer <fw@deneb.enyo.de> writes:
>> DJ, what do you think about this patch?
>
> I have no real problems with the patch, but two minor things that could
> be handled in a follow-up patch...
Thank you for the review.
Can I read it as ready to go into master?
>
> 1. The copy code for the old function doesn't handle overflow. We've
> seen bug reports for this before so should consider the edge cases.
> IMHO if a size_t value is larger than MAXINT, then MAXINT (or -1)
> should be stored instead of a randomly truncated value.
>
> 2. The new documentation makes no mention of the older "compatible"
> interface.
>
Both comments are valid to me and I can address them in a follow-up patch.
Martin
next prev parent reply other threads:[~2020-08-12 12:29 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 12:00 [PATCH] Use size_t for mallinfo fields Martin Liška
2020-07-07 12:17 ` Andreas Schwab
2020-07-07 13:07 ` Martin Liška
2020-07-07 13:19 ` H.J. Lu via Libc-alpha
2020-07-07 13:49 ` Florian Weimer via Libc-alpha
2020-07-07 13:52 ` Martin Liška
2020-07-07 14:22 ` Florian Weimer via Libc-alpha
2020-07-07 14:32 ` Andreas Schwab
2020-07-07 14:36 ` Florian Weimer via Libc-alpha
2020-07-08 7:25 ` Martin Liška
2020-07-08 7:24 ` Martin Liška
2020-07-23 10:23 ` Martin Liška
2020-07-23 14:38 ` Szabolcs Nagy
2020-07-27 12:08 ` Martin Liška
2020-07-27 12:21 ` Florian Weimer via Libc-alpha
2020-07-27 12:45 ` Martin Liška
2020-08-11 12:26 ` Martin Liška
2020-08-11 13:44 ` Florian Weimer
2020-08-11 17:08 ` DJ Delorie via Libc-alpha
2020-08-12 12:29 ` Martin Liška [this message]
2020-08-24 9:55 ` Martin Liška
2020-08-28 19:05 ` DJ Delorie via Libc-alpha
2020-08-31 13:35 ` H.J. Lu via Libc-alpha
2020-08-31 13:56 ` Adhemerval Zanella via Libc-alpha
2020-08-31 14:00 ` H.J. Lu via Libc-alpha
2020-08-31 14:10 ` Adhemerval Zanella via Libc-alpha
2020-09-01 17:26 ` Joseph Myers
2020-09-02 13:19 ` Martin Liška
2020-09-02 13:34 ` Adhemerval Zanella via Libc-alpha
2020-09-02 14:00 ` Carlos O'Donell via Libc-alpha
2020-09-02 16:11 ` DJ Delorie via Libc-alpha
2020-09-21 8:49 ` Martin Liška
2020-09-02 20:16 ` DJ Delorie via Libc-alpha
2020-09-02 20:24 ` Florian Weimer
2020-09-02 21:04 ` [PATCH/v2] " DJ Delorie via Libc-alpha
2020-09-03 11:17 ` Adhemerval Zanella via Libc-alpha
2020-09-03 21:33 ` DJ Delorie via Libc-alpha
2020-09-17 23:02 ` DJ Delorie via Libc-alpha
2020-09-02 20:25 ` [PATCH] " Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2f0cfa0-a348-e2bb-b3b6-f56454075f76@suse.cz \
--to=mliska@suse.cz \
--cc=dj@redhat.com \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).