From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 55B251F66E for ; Mon, 17 Aug 2020 14:21:37 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED5483861000; Mon, 17 Aug 2020 14:21:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED5483861000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1597674096; bh=WPbzbYEjDGeRz5Tc+Uo5RWjTWRQ5jvRfDdc6anii9fw=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=O5wGDQ8aps5mePACbYwwA2w55yI6yp9mSJNGDMldhnzgRUX0+zXDBZMWP+9mbYsoB UlfmtEdHPUFofPHZ0ddUG9M+yYY9saoIDOntWcMkY5EmkLs6HuY1wXgrW7eYjLhvaC zu50XxYJ17sKBUgter8huMyrMlKDc1y3ihCqSM8g= Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by sourceware.org (Postfix) with ESMTPS id BF2413861000 for ; Mon, 17 Aug 2020 14:21:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF2413861000 IronPort-SDR: IZyXSzB9fee4dWgQDXxbRfWfaVr/Dgh5ycNh9kEdxk6dvlHgsIwgk5Me5ycB0Bt0A2G4Xp7A7a AxNQrO1F377GtNeg8ReCNmkJh6LY6iCH/Yw3Wnrp++xHGRWqmRQNI0yff8AODLOyYUiuMP1lw9 z4A/zLV0AwPOVBQmvmhCXdssRk6+VGPvP8iXBiEw241f6uTFNrC7Bphb3qyo68WSCrtcyXxNv2 Gj9aaxNkWAJPK4z57q2SMFVGCYUmIoBBHokJXbwVBw1opj6/eK6ApKeckjkXQtehlKFXAo14HA dYI= X-IronPort-AV: E=Sophos;i="5.76,322,1592841600"; d="scan'208";a="146352060" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 17 Aug 2020 22:21:32 +0800 IronPort-SDR: r6A5v56FR/HQSOgO3btXQQF5OwqYgGQInuoKaHPF2FbYNjHViRvY7y4WZ/DIlBUONfLpSUN7YO h0Woogn5R/Xg== Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2020 07:08:32 -0700 IronPort-SDR: XyuYxCDjHhW27m3bzu/49NabFqJ3yrErCRGGQy5qguKwUzzTAWWaBUZ2ObCQnxb8oef569wRIW y9LGdQBsG2Fg== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2020 07:21:31 -0700 Date: Mon, 17 Aug 2020 15:21:28 +0100 (BST) To: Alistair Francis Subject: Re: [PATCH v4 07/18] sysv/linux: riscv: Fix dl-cache.h indentation In-Reply-To: <0afac7b4aa891fae06fccdef5f85d676747e7fa8.1597243100.git.alistair.francis@wdc.com> Message-ID: References: <0afac7b4aa891fae06fccdef5f85d676747e7fa8.1597243100.git.alistair.francis@wdc.com> User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Maciej W. Rozycki via Libc-alpha" Reply-To: "Maciej W. Rozycki" Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Wed, 12 Aug 2020, Alistair Francis wrote: > diff --git a/sysdeps/unix/sysv/linux/riscv/dl-cache.h b/sysdeps/unix/sysv/linux/riscv/dl-cache.h > index 331e6015f4..d2adfbc301 100644 > --- a/sysdeps/unix/sysv/linux/riscv/dl-cache.h > +++ b/sysdeps/unix/sysv/linux/riscv/dl-cache.h > @@ -31,7 +31,7 @@ > ((flags) == _DL_CACHE_DEFAULT_ID) > > /* If given a path to one of our library directories, adds every library > - directory via add_dir (), otherwise just adds the giver directory. On > + directory via add_dir (), otherwise just adds the given directory. On > RISC-V, libraries can be found in paths ending in: > - /lib64/lp64d > - /lib64/lp64 > @@ -41,15 +41,16 @@ > so this will add all of those paths. > > According to Joseph Myers: > - My reasoning for that would be: generic autoconf-configured (etc.) > - software may only know about using the lib directory, so you want the > - lib directory to be searched regardless of the ABI - but it's also > - useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all > - architectures and have that automatically imply /usr/local/lib64/lp64d > - etc. so that libraries can be found that come from software that does > - use the ABI-specific directories. */ > + My reasoning for that would be: generic autoconf-configured (etc.) > + software may only know about using the lib directory, so you want the > + lib directory to be searched regardless of the ABI - but it's also > + useful to be able to e.g. list /usr/local/lib in /etc/ld.so.conf for all > + architectures and have that automatically imply /usr/local/lib64/lp64d > + etc. so that libraries can be found that come from software that does > + use the ABI-specific directories. */ > + > #define add_system_dir(dir) \ > - do \ > + do \ Hmm, wrong patch submitted (06/19 from v3, which I asked to drop, rather than 07/19)? Also there's no 6/18 in the series, so something surely went wrong. NB I suggest splitting any fixes for typos or formatting anomalies off for a later submission unless made on a line that is changed for another reason anyway. Such changes can usually be committed as obvious right away with a note sent to the list and may be ignored for any backports. Maciej