From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2BE641F5AE for ; Tue, 14 Jul 2020 22:13:23 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BCEF83851C11; Tue, 14 Jul 2020 22:13:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BCEF83851C11 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1594764801; bh=EJf+hCT5jJXGJeBOV9tDSE+f9kUSjMGjWe38TXoYmXA=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pheuTebPG6Cm6u8hFI9US7cOehRekPkU/KLlS1U5CvW5uzMUJrX1PEnwRFW5ptrkY eC6unnG1CI8bSL6dx8UECnijahIXbIUREq/f5T/3z/nMjkZLjWjhY05W82ZoRniRCr 7N2EakVTMSdrrQA98sCSnl7QZVqXpyCDUzy6id2g= Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by sourceware.org (Postfix) with ESMTPS id CBD153858D34 for ; Tue, 14 Jul 2020 22:13:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CBD153858D34 IronPort-SDR: 1/gr6jHoGlR1lqmeDC2jOJZXZfbQWjgBrVd197L09eb53txDwynYJHZSkiD2CjBI54O3Qf6QAU CwEXpRTJs8mdTpk3/QYObWf4+uD6VK+pKyGsX021qcJHKJPnUtnohEG1+LN/qNqmiO/lQdjE22 pSs3VjoLvYGG5Vp/5ehLrr2n06rePBEuKI2MfyEPD4lCzIM6sIbzRy6JxtY4q1xiW5vnx16MAc jcm37M0zBDz7TtNyc60yH5m+0piuGayDhheBkiYmC2+YWiCXpVbb73tGiJqr+11O/6X88DiflY Dm4= X-IronPort-AV: E=Sophos;i="5.75,353,1589212800"; d="scan'208";a="146779614" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Jul 2020 06:13:17 +0800 IronPort-SDR: 4P0v5OTR1Sy+jD1vO3JXVtE1NGPbuchK7B+2usyQkOd8XJ98ZL0FrMjsxTXfApfe9DN6Kfaimz SI2+rkkUaUSh2MH3krJVLYQOdwnuSfoSk= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 15:01:43 -0700 IronPort-SDR: gTxpmHJ0zKHc6W+C66r+0oidiia4WfTp/XyeOmjVJo1e+VJXsW+uBiXudQ3iReT76Pudvejx4/ t0PZQwQRU+ZQ== WDCIronportException: Internal Received: from unknown (HELO redsun52) ([10.149.66.28]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2020 15:13:17 -0700 Date: Tue, 14 Jul 2020 23:13:12 +0100 (BST) To: Alistair Francis Subject: Re: [PATCH v3 14/19] RISC-V: Fix llrint and llround missing exceptions on RV32 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Maciej W. Rozycki via Libc-alpha" Reply-To: "Maciej W. Rozycki" Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Sun, 12 Jul 2020, Alistair Francis via Libc-alpha wrote: > Similar to the fix for MIPS, ARM and S/390, RV32 is missing > correct exception on overflow from llrint and llround functions because > cast from floating-point types to long long do not result in correct > exceptions on overflow. Odd grammar and formatting. > diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h > new file mode 100644 > index 0000000000..2ab1497587 > --- /dev/null > +++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h > @@ -0,0 +1,38 @@ > +/* Fix for conversion of floating point to integer overflow. RISC-V version. Two spaces after a sentence please. > +/* The generic libgcc2.c conversions from floating point > + to long long may not raise the correct exceptions on overflow (and > + may raise spurious "inexact" exceptions even in non-overflow cases, > + see ). */ Odd formatting as well, how about: /* The generic libgcc2.c conversions from floating point to long long may not raise the correct exceptions on overflow (and may raise spurious "inexact" exceptions even in non-overflow cases, see ). */ ? Otherwise OK. Maciej