From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B8F991F4DA for ; Thu, 20 Oct 2022 00:01:48 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 68070385380E for ; Thu, 20 Oct 2022 00:01:44 +0000 (GMT) Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 40F50385416D for ; Thu, 20 Oct 2022 00:01:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 40F50385416D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,196,1661846400"; d="scan'208";a="85068554" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 19 Oct 2022 16:01:31 -0800 IronPort-SDR: XaIttukijS/ZLs9JAsRkBocxjbHM+DFVthzwe6sURKA44rq4+5fFvKG/qkjIqXgYQE4/BM81dP LY4OXoYTl05Y3K9xVh/WCOoVj0WizzoCcPk2whSj1AWb8f0fSuxYODUh5xLPf1os6OT1rj1ZYg NpGnOD8LrXousOPwjO9D3989ATvn+of0rLwEyD7+wlLFcnYvvDZmVJF6Og8KLZiQLiIT6CX5qn 7ksd100kcp5sO5jBk5nkcBZNbCRlgbwGFVgPfGI+4tr0DiA7hY2U3p5gtNq2QEZP/7NCTIgORJ Ogo= Date: Thu, 20 Oct 2022 00:01:25 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella Subject: Re: [PATCH 22/30] Linux: Assume and consolidate getsockname wire-up syscall In-Reply-To: <20221019221433.1082017-23-adhemerval.zanella@linaro.org> Message-ID: References: <20221019221433.1082017-1-adhemerval.zanella@linaro.org> <20221019221433.1082017-23-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Wed, 19 Oct 2022, Adhemerval Zanella via Libc-alpha wrote: > And disable if kernel does not support it. How did you determine what #undefs to add? I'd have expected a #undef for 32-bit SPARC at least (where getpeername and getsockname were only added to the compat syscall table for SPARC in 4.20 (Linux commit 1f2b5b8e2df4591fbca430aff9c5a072dcc0f408)). -- Joseph S. Myers joseph@codesourcery.com