From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id BED501F8C8 for ; Wed, 22 Sep 2021 18:10:14 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CFB683857C53 for ; Wed, 22 Sep 2021 18:10:13 +0000 (GMT) Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 6F9E23858D29 for ; Wed, 22 Sep 2021 18:10:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F9E23858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 99MccH+upcElWxLHnqoz6UOWJD7MecxJTpNwYoTfBb1ax92ZOi5mc7MuAt96Q9fCEgrkkuZ2Ax F0DV7YCQ84+0iX3l260B3tXU5sPIBFBbb8rGVoiLu3+9CAELTOJFn+hBBHg3TmXRA78m0Q+0qH zEsbsClVYhscGFblNsNGokh7LQ+B/svA82Pv7bWfkajajMVvfg7slOAJazY/mpyF1Nj4RwWoxp b1U+RYZjC930AZFmQ3WxY4NC6B7gRRb9i6pYVEpKeqlQcP85FQGoX8nWOesM1/k82mgR+5vdzt i01bSAJO11LT7gNg0FVC6ObT X-IronPort-AV: E=Sophos;i="5.85,314,1624348800"; d="scan'208";a="68680650" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 22 Sep 2021 10:10:01 -0800 IronPort-SDR: AoEnQU2GhyZAcfayGIweTTSxOBU+AMTiPOm9O2qNSYav6Om0CgvUU62Pb7fecPR2XdMK8fqevo Bnm0hMKyxyYT78QCEPGS2Ju2scdIPfKg19TmiUKyRRT84XlXMzTLykG5yFTdNQz22aYcxUE9fP usa63NLvpx3JAWnvEY7DxqCLLgqvgAl3X8O0knlP3IXlpVNWW+jwdi3Fjag+ioealgBu36rp8H avNTE3h6dfG3BYHWp4jENb6DF4Odgfe9DaDuvCMKNjb4d4XA8/47Ljvdbf1a524Cn5Pw8QyZjw V0Y= Date: Wed, 22 Sep 2021 18:09:56 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Carlos O'Donell Subject: Re: PING^2: [PATCH] elf: Avoid nested functions in the loader (all ports) [BZ #27220] In-Reply-To: Message-ID: References: <20210823043648.2648608-1-maskray@google.com> <87tuj255se.fsf@oldenburg.str.redhat.com> <20210904035235.giercjqdwzjukxb5@google.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Weimer , Fangrui Song via Libc-alpha Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Wed, 22 Sep 2021, Carlos O'Donell via Libc-alpha wrote: > - Split this patch up into more logical changes. I'm not convinced there's much scope for splitting up this patch more; it is a logical change (versions that changed only some architectures were a lot uglier). My comment about logical changes was a more generic one, not suggesting that this particular patch should be split up further. -- Joseph S. Myers joseph@codesourcery.com