From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,PDS_RDNS_DYNAMIC_FP, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1D7BA1F8C6 for ; Thu, 12 Aug 2021 17:21:01 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 98FDD3953CE6 for ; Thu, 12 Aug 2021 17:20:59 +0000 (GMT) Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 641433844015 for ; Thu, 12 Aug 2021 17:20:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 641433844015 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: UEidkavYmPlr5XYgayVdnUls8nsPxCKtNhlPlkzggBRg/2EG21L9rFjUxxBluNSKxojHdF+NtW oRGqvhHzZYjseGfoGpqWOeveqRR30Lh0bxvVJhDR1Qrwlz0nccl3mR0/Yph86J9deZrWpFI1si SbZq4+5Igsm4dLE42BV6JZGHMra7pQAQZ4/Qw4lfN550FgBDuDWTX6IjSUOinOAZcSGfvOge7X h301R6kXcvsFkLvAjNkaZqTlX3sNo9fwzZCfjVliyy3ZMd2DLFEjHZ4sLShd6Up2GpHgcaUoKB zioUnVt20neDrwvb2zirhOi9 X-IronPort-AV: E=Sophos;i="5.84,316,1620720000"; d="scan'208";a="64591585" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 12 Aug 2021 09:20:47 -0800 IronPort-SDR: dD0rDq3rFCg/mVbhk5QKqLXvw4tcnyzt3UfJP755+VclGVJIoeb9l31BPBjmPMTj8gf0iPluwY 3Zxb0zdjQ2QZ3P8o4OkB4fbSwDBvcTWxHGDDoO+K/8a7JYKq3wjBtSLBZGa3pbvqhm952QGVrz QrSoHLVejZ356dqTFNuP75EpCo5dVwFFJHIyueiZXKsz7WhkxLyInGZl1MjzJz8c9zVOQhTzIB 0z0JGzevrhTwiDYVnNjTW6A31PmSkF12e5n0K3J96NOW9f1TXYo4uWYO4hf+wnwFzuljEy7WTi SWM= Date: Thu, 12 Aug 2021 17:20:41 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Xi Ruoyao Subject: Re: [PATCH] mips: align stack in clone [BZ #28223] In-Reply-To: <07cf2ef7f47070979089f880d91a0369c4efa978.camel@mengyan1223.wang> Message-ID: References: <07cf2ef7f47070979089f880d91a0369c4efa978.camel@mengyan1223.wang> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Fri, 13 Aug 2021, Xi Ruoyao via Libc-alpha wrote: > The MIPS O32 ABI requires 4 byte aligned stack, and the MIPS N64 and N32 > ABI require 8 byte aligned stack. Previously if the caller passed an > unaligned stack to clone the the child misbehaved. > > Fixes bug 28223. This patch is OK. -- Joseph S. Myers joseph@codesourcery.com