unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Fangrui Song <maskray@google.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] elf: Drop elf/tls-macros.h in favor of __thread and tls_model attributes [BZ #28152] [BZ #28205]
Date: Wed, 11 Aug 2021 21:54:03 +0000	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2108112150160.2616829@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20210811213159.1647462-1-maskray@google.com>

On Wed, 11 Aug 2021, Fangrui Song via Libc-alpha wrote:

> As a future clean-up, TLS_LD/TLS_IE/TLS_IE macros can be removed from
> sysdeps/*/tls-macros.h. aarch64 TLS_GD definition should be retained to
> test traditional TLS GD while the toolchain default is TLSDESC.

It might be better to test different TLS dialects through the compiler 
generating appropriate code rather than keeping such macros around.  E.g., 
have a way for architectures to declare a set of supported -mtls-dialect= 
arguments (or detect them at configure time, at present there's a test for 
-mtls-dialect=gnu2 support), and, when more than one dialect is supported, 
run various tests explicitly for each dialect supported by the compiler, 
in addition to testing whatever the default dialect is.

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2021-08-11 21:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 21:31 [PATCH] elf: Drop elf/tls-macros.h in favor of __thread and tls_model attributes [BZ #28152] [BZ #28205] Fangrui Song via Libc-alpha
2021-08-11 21:54 ` Joseph Myers [this message]
2021-08-11 22:11   ` Fangrui Song via Libc-alpha
2021-08-12  9:16     ` Szabolcs Nagy via Libc-alpha
2021-08-12 15:36     ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2108112150160.2616829@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=maskray@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).